Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 728653003: Navigation transitions (web to native app): Get names and rects of transition elements (Step 5) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 42629a1e3addd9e680342526d0c579c970375d5e..6a147a02c0c9125aeb0fac070579889f4c678591 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2563,28 +2563,6 @@ void RenderFrameImpl::didUpdateCurrentHistoryItem(blink::WebLocalFrame* frame) {
render_view_->didUpdateCurrentHistoryItem(frame);
}
-// TODO(zhenw): This will be removed once the blink side implementation is done.
-void RenderFrameImpl::addNavigationTransitionData(
- const blink::WebString& allowed_destination_host_pattern,
- const blink::WebString& selector,
- const blink::WebString& markup,
- const blink::WebVector<blink::WebString>& web_ids,
- const blink::WebVector<blink::WebRect>& web_rects) {
- FrameHostMsg_AddNavigationTransitionData_Params params;
- params.render_frame_id = routing_id_;
- params.allowed_destination_host_pattern =
- allowed_destination_host_pattern.utf8();
- params.selector = selector.utf8();
- params.markup = markup.utf8();
- params.elements.resize(web_ids.size());
- for (size_t i = 0; i < web_ids.size(); i++) {
- params.elements[i].id = web_ids[i].utf8();
- params.elements[i].rect = gfx::Rect(web_rects[i]);
- }
-
- Send(new FrameHostMsg_AddNavigationTransitionData(params));
-}
-
void RenderFrameImpl::addNavigationTransitionData(
const blink::WebTransitionElementData& data) {
FrameHostMsg_AddNavigationTransitionData_Params params;
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698