Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 728653003: Navigation transitions (web to native app): Get names and rects of transition elements (Step 5) (Closed)

Created:
6 years, 1 month ago by Zhen Wang
Modified:
6 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Navigation transitions (web to native app): Get names and rects of transition elements (Step 5) Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions ================ Originally this was a 3-way patch since it involves API change in WebFrameClient.h. After the chrome side impl was committed (step 1), we found that it is better to pass struct instead of long list of params. So this turns out to be a 5-way patch. Here are the 5 steps: 1. Chrome side - save the data (https://codereview.chromium.org/652283002/). 2. Blink side - getting the data and introduce struct WebTransitionElementData, but still using long list of params (https://codereview.chromium.org/654953002/). 3. Chrome side - implement the API with WebTransitionElementData (https://codereview.chromium.org/679813003/). 4. Blink side - remove old APIs that use long list of params and start to use new API with WebTransitionElementData (https://codereview.chromium.org/721973002/). 5. Chrome side - remove redundent implmentations of the old APIs (this CL). BUG=370696 Committed: https://crrev.com/344eaadb0f57fa347e617d2c08e8d4fb8c824e7d Cr-Commit-Position: refs/heads/master@{#304232}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhen Wang
ptal
6 years, 1 month ago (2014-11-14 15:33:08 UTC) #2
nasko
LGTM
6 years, 1 month ago (2014-11-14 16:48:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728653003/20001
6 years, 1 month ago (2014-11-14 17:06:07 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-14 17:53:59 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 17:54:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/344eaadb0f57fa347e617d2c08e8d4fb8c824e7d
Cr-Commit-Position: refs/heads/master@{#304232}

Powered by Google App Engine
This is Rietveld 408576698