Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 72863002: [DevTools] Added regex support to console filters. (Closed)

Created:
7 years, 1 month ago by Dmitry Zvorygin
Modified:
7 years ago
Reviewers:
eustas, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[DevTools] Added regex support to console filters. BUG=318308 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163188

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed comments. #

Patch Set 3 : Fixed css color format. #

Total comments: 6

Patch Set 4 : Fixed comments. #

Patch Set 5 : Codereview issues. #

Total comments: 4

Patch Set 6 : Fixed witdh. #

Total comments: 1

Patch Set 7 : Added missing semicolon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M Source/devtools/front_end/ConsoleView.js View 1 2 3 4 5 6 2 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/FilterBar.js View 1 2 3 4 5 6 4 chunks +33 lines, -6 lines 0 comments Download
M Source/devtools/front_end/filter.css View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dmitry Zvorygin
Please take a look.
7 years, 1 month ago (2013-11-14 17:28:35 UTC) #1
eustas
https://codereview.chromium.org/72863002/diff/1/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://codereview.chromium.org/72863002/diff/1/Source/devtools/front_end/FilterBar.js#newcode233 Source/devtools/front_end/FilterBar.js:233: this._regex = null semicolon missing https://codereview.chromium.org/72863002/diff/1/Source/devtools/front_end/FilterBar.js#newcode239 Source/devtools/front_end/FilterBar.js:239: // Silent ...
7 years, 1 month ago (2013-11-15 05:13:32 UTC) #2
Dmitry Zvorygin
Please take a look. https://codereview.chromium.org/72863002/diff/1/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://codereview.chromium.org/72863002/diff/1/Source/devtools/front_end/FilterBar.js#newcode233 Source/devtools/front_end/FilterBar.js:233: this._regex = null On 2013/11/15 ...
7 years, 1 month ago (2013-11-15 10:39:12 UTC) #3
vsevik
https://chromiumcodereview.appspot.com/72863002/diff/90001/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://chromiumcodereview.appspot.com/72863002/diff/90001/Source/devtools/front_end/FilterBar.js#newcode180 Source/devtools/front_end/FilterBar.js:180: this._regexCheckBox = this._filterElement.createChild("input"); 4 spaces indent in blink. https://chromiumcodereview.appspot.com/72863002/diff/90001/Source/devtools/front_end/filter.css ...
7 years ago (2013-11-27 13:37:22 UTC) #4
Dmitry Zvorygin
Please take a look. https://codereview.chromium.org/72863002/diff/90001/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://codereview.chromium.org/72863002/diff/90001/Source/devtools/front_end/FilterBar.js#newcode180 Source/devtools/front_end/FilterBar.js:180: this._regexCheckBox = this._filterElement.createChild("input"); On 2013/11/27 ...
7 years ago (2013-11-27 17:52:23 UTC) #5
vsevik
https://codereview.chromium.org/72863002/diff/160001/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://codereview.chromium.org/72863002/diff/160001/Source/devtools/front_end/FilterBar.js#newcode254 Source/devtools/front_end/FilterBar.js:254: if (filterQuery) { nit: if (!filterQuery) return; https://codereview.chromium.org/72863002/diff/160001/Source/devtools/front_end/filter.css File ...
7 years ago (2013-11-28 10:29:10 UTC) #6
Dmitry Zvorygin
Please take a look. https://codereview.chromium.org/72863002/diff/160001/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://codereview.chromium.org/72863002/diff/160001/Source/devtools/front_end/FilterBar.js#newcode254 Source/devtools/front_end/FilterBar.js:254: if (filterQuery) { On 2013/11/28 ...
7 years ago (2013-11-28 13:48:33 UTC) #7
vsevik
lgtm https://chromiumcodereview.appspot.com/72863002/diff/180001/Source/devtools/front_end/FilterBar.js File Source/devtools/front_end/FilterBar.js (right): https://chromiumcodereview.appspot.com/72863002/diff/180001/Source/devtools/front_end/FilterBar.js#newcode253 Source/devtools/front_end/FilterBar.js:253: this._regex = null ; is missing
7 years ago (2013-12-04 11:15:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/72863002/200001
7 years ago (2013-12-04 17:58:38 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-04 20:49:44 UTC) #10
Message was sent while issue was closed. 
Change committed as 163188

Powered by Google App Engine
This is Rietveld 408576698