Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 728613002: Make the embedder API use the ChannelManager. (Closed)

Created:
6 years, 1 month ago by viettrungluu
Modified:
6 years, 1 month ago
Reviewers:
yzshen1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make the embedder API use the ChannelManager. (This doesn't actually change any functionality.) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/96c7a5d38b72b619422eaa723a6b6695b2c1be17

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Total comments: 1

Patch Set 3 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -99 lines) Patch
M mojo/edk/embedder/channel_info_forward.h View 1 chunk +1 line, -10 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 1 2 3 chunks +18 lines, -23 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 7 chunks +26 lines, -30 lines 0 comments Download
M mojo/edk/embedder/embedder_internal.h View 1 chunk +28 lines, -0 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 1 2 chunks +1 line, -11 lines 0 comments Download
M mojo/edk/embedder/test_embedder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/embedder/test_embedder.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/edk/system/channel_manager.h View 1 chunk +17 lines, -8 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 3 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 1 month ago (2014-11-13 20:30:06 UTC) #1
yzshen1
https://codereview.chromium.org/728613002/diff/1/mojo/edk/embedder/embedder.cc File mojo/edk/embedder/embedder.cc (right): https://codereview.chromium.org/728613002/diff/1/mojo/edk/embedder/embedder.cc#newcode86 mojo/edk/embedder/embedder.cc:86: // TODO(vtl): Ditto. nit: It is not clear what ...
6 years, 1 month ago (2014-11-13 21:22:24 UTC) #2
viettrungluu
Thanks, PTAL. https://codereview.chromium.org/728613002/diff/1/mojo/edk/embedder/embedder.cc File mojo/edk/embedder/embedder.cc (right): https://codereview.chromium.org/728613002/diff/1/mojo/edk/embedder/embedder.cc#newcode86 mojo/edk/embedder/embedder.cc:86: // TODO(vtl): Ditto. On 2014/11/13 21:22:24, yzshen1 ...
6 years, 1 month ago (2014-11-13 22:37:39 UTC) #3
yzshen1
lgtm https://codereview.chromium.org/728613002/diff/20001/mojo/edk/embedder/embedder.h File mojo/edk/embedder/embedder.h (right): https://codereview.chromium.org/728613002/diff/20001/mojo/edk/embedder/embedder.h#newcode93 mojo/edk/embedder/embedder.h:93: // Destroys a channel that was created using ...
6 years, 1 month ago (2014-11-13 22:48:32 UTC) #4
viettrungluu
Thanks. On 2014/11/13 22:48:32, yzshen1 wrote: > lgtm > > https://codereview.chromium.org/728613002/diff/20001/mojo/edk/embedder/embedder.h > File mojo/edk/embedder/embedder.h (right): ...
6 years, 1 month ago (2014-11-13 22:56:16 UTC) #5
viettrungluu
6 years, 1 month ago (2014-11-13 23:00:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
96c7a5d38b72b619422eaa723a6b6695b2c1be17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698