Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 728593003: Add a sample app that draws with Ganesh (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 14

Patch Set 2 : Cleanup #

Patch Set 3 : Remove extra edit #

Patch Set 4 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -88 lines) Patch
M examples/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + examples/ganesh_app/BUILD.gn View 1 2 3 1 chunk +18 lines, -11 lines 0 comments Download
A + examples/ganesh_app/DEPS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + examples/ganesh_app/ganesh_app.cc View 4 chunks +8 lines, -7 lines 0 comments Download
A + examples/ganesh_app/painter.h View 1 3 chunks +15 lines, -21 lines 0 comments Download
A + examples/ganesh_app/painter.cc View 1 2 3 9 chunks +90 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-14 00:18:31 UTC) #1
jamesr
lgtm https://codereview.chromium.org/728593003/diff/1/examples/ganesh_app/BUILD.gn File examples/ganesh_app/BUILD.gn (right): https://codereview.chromium.org/728593003/diff/1/examples/ganesh_app/BUILD.gn#newcode16 examples/ganesh_app/BUILD.gn:16: "//examples/sample_app:spinning_cube", don't need https://codereview.chromium.org/728593003/diff/1/examples/ganesh_app/BUILD.gn#newcode18 examples/ganesh_app/BUILD.gn:18: "//examples/surfaces_app:util", don't think ...
6 years, 1 month ago (2014-11-14 00:36:42 UTC) #2
abarth-chromium
Thanks! Fixenated. https://codereview.chromium.org/728593003/diff/1/examples/ganesh_app/BUILD.gn File examples/ganesh_app/BUILD.gn (right): https://codereview.chromium.org/728593003/diff/1/examples/ganesh_app/BUILD.gn#newcode18 examples/ganesh_app/BUILD.gn:18: "//examples/surfaces_app:util", On 2014/11/14 at 00:36:42, jamesr wrote: ...
6 years, 1 month ago (2014-11-14 00:40:14 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-14 00:41:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
c21aa7c4a49f650745e0f39487e9c97c8c935122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698