Issue 728553003: [turbofan] round robin register picking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 728553003: [turbofan] round robin register picking (Closed)

Created:
6 years, 1 month ago by dcarney

Modified:
6 years, 1 month ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] round robin register picking R=titzer@chromium.org BUG=

Patch Set 2 : rebase #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
	M	src/compiler/register-allocator.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/compiler/register-allocator.cc	View	1	4 chunks	+18 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

titzer

https://codereview.chromium.org/728553003/diff/1/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/728553003/diff/1/src/compiler/register-allocator.cc#newcode1869 src/compiler/register-allocator.cc:1869: int reg = start % count; On second thought, ...

6 years, 1 month ago (2014-11-19 14:02:08 UTC) #4

dcarney

6 years, 1 month ago (2014-11-21 14:04:48 UTC) #5

On 2014/11/19 13:58:37, titzer wrote:
> Easy as pie. LGTM if numbers improve.

numbers are all over the place. closing issue.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 728553003: [turbofan] round robin register picking (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Messages