Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issue 72853002: Try to fix loading COM objects living in %CommonProgramFiles% on build slaves. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, csharp, Vadim Sh.
Base URL:
https://chromium.googlesource.com/a/chromium/tools/build.git@master
Visibility:
Public.

Description

Try to fix loading COM objects living in %CommonProgramFiles% on build slaves. This will likely have some side effects on the tests, now they should be able to load many COM objects that couldn't be loaded before. R=iannucci@chromium.org BUG=319379 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M slave/run_slave.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
7 years, 1 month ago (2013-11-14 16:55:46 UTC) #1
iannucci
On 2013/11/14 16:55:46, M-A Ruel wrote: lgtm
7 years, 1 month ago (2013-11-14 18:26:53 UTC) #2
iannucci
On 2013/11/14 18:26:53, iannucci wrote: > On 2013/11/14 16:55:46, M-A Ruel wrote: > > lgtm ...
7 years, 1 month ago (2013-11-14 18:27:13 UTC) #3
iannucci
On 2013/11/14 18:27:13, iannucci wrote: > On 2013/11/14 18:26:53, iannucci wrote: > > On 2013/11/14 ...
7 years, 1 month ago (2013-11-14 18:29:09 UTC) #4
iannucci
On 2013/11/14 18:29:09, iannucci wrote: > On 2013/11/14 18:27:13, iannucci wrote: > > On 2013/11/14 ...
7 years, 1 month ago (2013-11-14 18:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/72853002/1
7 years, 1 month ago (2013-11-14 18:31:16 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 18:32:03 UTC) #7
Message was sent while issue was closed.
Change committed as 235190

Powered by Google App Engine
This is Rietveld 408576698