Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 728503002: Really enable deprecation warnings for Android framework. (Closed)

Created:
6 years, 1 month ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Really enable deprecation warnings for Android framework. Left out of a previous CL to reenable. (We had the define added in two places for some reason...) Committed: https://skia.googlesource.com/skia/+/a18cc77c338e79b5de5c7ee883da31f6befad9bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
6 years, 1 month ago (2014-11-13 16:10:59 UTC) #2
djsollen
lgtm
6 years, 1 month ago (2014-11-13 18:42:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728503002/1
6 years, 1 month ago (2014-11-17 18:21:35 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 18:29:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a18cc77c338e79b5de5c7ee883da31f6befad9bc

Powered by Google App Engine
This is Rietveld 408576698