Remove PushPermissionClient.

Remove PushPermissionClient.

I found that I still need a multi purpose dispatcher for the Push API. I'll re-implement the permission request in a followup CL.

BUG=389194
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185297

[Michael van Ouwerkerk, 2014-11-13 11:42:39]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2014-11-13 11:42:39]

Peter, could you take a look please?

[Peter Beverloo, 2014-11-13 11:45:18]

lgtm

https://codereview.chromium.org/728443002/diff/1/Source/modules/push_messagin...
File Source/modules/push_messaging/PushManager.h (left):

https://codereview.chromium.org/728443002/diff/1/Source/modules/push_messagin...
Source/modules/push_messaging/PushManager.h:33: void trace(Visitor*) { }
nit: This needs to be marked as override.

[Michael van Ouwerkerk, 2014-11-13 12:49:42]

mvanouwerkerk@chromium.org changed reviewers:
+ mkwst@chromium.org

[Michael van Ouwerkerk, 2014-11-13 12:49:43]

Thanks Peter!

Mike, could you take a look as owner please?

https://codereview.chromium.org/728443002/diff/1/Source/modules/push_messagin...
File Source/modules/push_messaging/PushManager.h (left):

https://codereview.chromium.org/728443002/diff/1/Source/modules/push_messagin...
Source/modules/push_messaging/PushManager.h:33: void trace(Visitor*) { }
On 2014/11/13 11:45:17, Peter Beverloo wrote:
> nit: This needs to be marked as override.

Done.

[Michael van Ouwerkerk, 2014-11-13 14:22:02]

https://codereview.chromium.org/728443002/diff/1/Source/modules/push_messagin...
File Source/modules/push_messaging/PushManager.h (left):

https://codereview.chromium.org/728443002/diff/1/Source/modules/push_messagin...
Source/modules/push_messaging/PushManager.h:33: void trace(Visitor*) { }
On 2014/11/13 12:49:43, Michael van Ouwerkerk wrote:
> On 2014/11/13 11:45:17, Peter Beverloo wrote:
> > nit: This needs to be marked as override.
> 
> Done.

Actually, that does not compile :-( So no.

[Mike West, 2014-11-13 14:27:01]

LGTM.

[Michael van Ouwerkerk, 2014-11-13 14:33:41]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2014-11-13 14:34:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728443002/40001

[commit-bot: I haz the power, 2014-11-13 15:27:32]

Committed patchset #3 (id:40001) as 185297