Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 72843002: <webview>: Give tabIndex -1 so that tab order is not affected (Closed)

Created:
7 years, 1 month ago by Fady Samuel
Modified:
7 years, 1 month ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

<webview>: Give tabIndex -1 so that tab order is not affected BUG=231664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/renderer/resources/extensions/web_view.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Fady Samuel
7 years, 1 month ago (2013-11-14 16:49:00 UTC) #1
lazyboy
lgtm
7 years, 1 month ago (2013-11-14 18:45:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-14 18:49:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224508
7 years, 1 month ago (2013-11-14 21:13:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-14 21:21:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-14 22:39:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-15 02:36:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-15 04:27:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224898
7 years, 1 month ago (2013-11-15 08:58:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-15 12:08:18 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=225117
7 years, 1 month ago (2013-11-15 16:26:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-15 22:58:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/72843002/1
7 years, 1 month ago (2013-11-16 01:19:00 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:27:33 UTC) #14
Message was sent while issue was closed. 
Change committed as 235702

Powered by Google App Engine
This is Rietveld 408576698