Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 728323002: separate c headers (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -96 lines) Patch
A include/c/sk_canvas.h View 1 chunk +33 lines, -0 lines 0 comments Download
A include/c/sk_image.h View 1 chunk +31 lines, -0 lines 0 comments Download
A include/c/sk_paint.h View 1 chunk +27 lines, -0 lines 0 comments Download
A include/c/sk_path.h View 1 chunk +45 lines, -0 lines 0 comments Download
M include/c/sk_surface.h View 2 chunks +10 lines, -96 lines 0 comments Download
A include/c/sk_types.h View 1 chunk +82 lines, -0 lines 0 comments Download
M src/c/sk_surface.cpp View 3 chunks +66 lines, -0 lines 0 comments Download
M tests/CTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728323002/1
6 years, 1 month ago (2014-11-17 04:40:52 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-17 04:40:52 UTC) #3
reed2
6 years, 1 month ago (2014-11-17 04:42:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-11-17 10:41:00 UTC) #7
reed1
lgtm
6 years, 1 month ago (2014-11-17 14:15:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728323002/1
6 years, 1 month ago (2014-11-17 14:15:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 14:15:45 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73c250112026b84b38e6dc8c93e0cfc31918dc9d

Powered by Google App Engine
This is Rietveld 408576698