Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 7283024: Remove the dependency on app_base from some targets. (Closed)

Created:
9 years, 5 months ago by tfarina
Modified:
9 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, apatrick_chromium, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove the dependency on app_base from some targets. BUG=72317 TEST=None R=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91045

Patch Set 1 #

Patch Set 2 : add ui_gfx dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/imagediff/image_diff.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 5 months ago (2011-06-29 21:57:55 UTC) #1
Robert Sesek
9 years, 5 months ago (2011-06-29 21:59:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698