Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: build/common.gypi

Issue 728233003: Reland https://codereview.chromium.org/292153006 with minor changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use strip -x for both non-ASan and ASan builds Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2143 matching lines...) Expand 10 before | Expand all | Expand 10 after
2154 ['asan==1 and OS=="linux" and chromeos==0', { 2154 ['asan==1 and OS=="linux" and chromeos==0', {
2155 'use_custom_libcxx%': 1, 2155 'use_custom_libcxx%': 1,
2156 }], 2156 }],
2157 ['ubsan==1', { 2157 ['ubsan==1', {
2158 'clang%': 1, 2158 'clang%': 1,
2159 }], 2159 }],
2160 ['ubsan_vptr==1', { 2160 ['ubsan_vptr==1', {
2161 'clang%': 1, 2161 'clang%': 1,
2162 }], 2162 }],
2163 ['asan==1 and OS=="mac"', { 2163 ['asan==1 and OS=="mac"', {
2164 # TODO(glider): we do not strip ASan binaries until the dynamic ASan 2164 'mac_strip_release': 1,
2165 # runtime is fully adopted. See http://crbug.com/242503.
2166 'mac_strip_release': 0,
2167 }], 2165 }],
2168 ['tsan==1', { 2166 ['tsan==1', {
2169 'use_custom_libcxx%': 1, 2167 'use_custom_libcxx%': 1,
2170 }], 2168 }],
2171 ['msan==1', { 2169 ['msan==1', {
2172 # Use a just-built, MSan-instrumented libc++ instead of the system-wide 2170 # Use a just-built, MSan-instrumented libc++ instead of the system-wide
2173 # libstdc++. This is required to avoid false positive reports whenever 2171 # libstdc++. This is required to avoid false positive reports whenever
2174 # the C++ standard library is used. 2172 # the C++ standard library is used.
2175 'use_custom_libcxx%': 1, 2173 'use_custom_libcxx%': 1,
2176 # Running the V8-generated code on an ARM simulator is a powerful hack 2174 # Running the V8-generated code on an ARM simulator is a powerful hack
(...skipping 2874 matching lines...) Expand 10 before | Expand all | Expand 10 after
5051 }], 5049 }],
5052 ], 5050 ],
5053 }, 5051 },
5054 'postbuild_name': 'Change Mach-O Flags', 5052 'postbuild_name': 'Change Mach-O Flags',
5055 'action': [ 5053 'action': [
5056 '<(change_mach_o_flags_path)', 5054 '<(change_mach_o_flags_path)',
5057 '>@(change_mach_o_flags_options)', 5055 '>@(change_mach_o_flags_options)',
5058 ], 5056 ],
5059 }, 5057 },
5060 ], 5058 ],
5061 'conditions': [
5062 ['asan==1', {
5063 'variables': {
5064 'asan_saves_file': 'asan.saves',
5065 },
5066 'xcode_settings': {
5067 'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
5068 },
5069 }],
5070 ],
5071 'target_conditions': [ 5059 'target_conditions': [
5072 ['mac_pie==1 and release_valgrind_build==0', { 5060 ['mac_pie==1 and release_valgrind_build==0', {
5073 # Turn on position-independence (ASLR) for executables. When 5061 # Turn on position-independence (ASLR) for executables. When
5074 # PIE is on for the Chrome executables, the framework will 5062 # PIE is on for the Chrome executables, the framework will
5075 # also be subject to ASLR. 5063 # also be subject to ASLR.
5076 # Don't do this when building for Valgrind, because Valgrind 5064 # Don't do this when building for Valgrind, because Valgrind
5077 # doesn't understand slide. TODO: Make Valgrind on Mac OS X 5065 # doesn't understand slide. TODO: Make Valgrind on Mac OS X
5078 # understand slide, and get rid of the Valgrind check. 5066 # understand slide, and get rid of the Valgrind check.
5079 'xcode_settings': { 5067 'xcode_settings': {
5080 'OTHER_LDFLAGS': [ 5068 'OTHER_LDFLAGS': [
(...skipping 19 matching lines...) Expand all
5100 'STRIP_INSTALLED_PRODUCT': 'YES', 5088 'STRIP_INSTALLED_PRODUCT': 'YES',
5101 'target_conditions': [ 5089 'target_conditions': [
5102 ['_type=="shared_library" or _type=="loadable_module"', { 5090 ['_type=="shared_library" or _type=="loadable_module"', {
5103 # The Xcode default is to strip debugging symbols 5091 # The Xcode default is to strip debugging symbols
5104 # only (-S). Local symbols should be stripped as 5092 # only (-S). Local symbols should be stripped as
5105 # well, which will be handled by -x. Xcode will 5093 # well, which will be handled by -x. Xcode will
5106 # continue to insert -S when stripping even when 5094 # continue to insert -S when stripping even when
5107 # additional flags are added with STRIPFLAGS. 5095 # additional flags are added with STRIPFLAGS.
5108 'STRIPFLAGS': '-x', 5096 'STRIPFLAGS': '-x',
5109 }], # _type=="shared_library" or _type=="loadable_modul e" 5097 }], # _type=="shared_library" or _type=="loadable_modul e"
5110 ['_type=="executable"', {
5111 'conditions': [
5112 ['asan==1', {
5113 'STRIPFLAGS': '-s $(CHROMIUM_STRIP_SAVE_FILE)',
5114 }]
5115 ],
5116 }], # _type=="executable" and asan==1
5117 ], # target_conditions 5098 ], # target_conditions
5118 }, # xcode_settings 5099 }, # xcode_settings
5119 }, # configuration "Release" 5100 }, # configuration "Release"
5120 }, # configurations 5101 }, # configurations
5121 }, { # mac_real_dsym != 1 5102 }, { # mac_real_dsym != 1
5122 # To get a fast fake .dSYM bundle, use a post-build step to 5103 # To get a fast fake .dSYM bundle, use a post-build step to
5123 # produce the .dSYM and strip the executable. strip_from_xcode 5104 # produce the .dSYM and strip the executable. strip_from_xcode
5124 # only operates in the Release configuration. 5105 # only operates in the Release configuration.
5125 'postbuilds': [ 5106 'postbuilds': [
5126 { 5107 {
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
5842 # settings in target dicts. SYMROOT is a special case, because many other 5823 # settings in target dicts. SYMROOT is a special case, because many other
5843 # Xcode variables depend on it, including variables such as 5824 # Xcode variables depend on it, including variables such as
5844 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5825 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5845 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5826 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5846 # files to appear (when present) in the UI as actual files and not red 5827 # files to appear (when present) in the UI as actual files and not red
5847 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5828 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5848 # and therefore SYMROOT, needs to be set at the project level. 5829 # and therefore SYMROOT, needs to be set at the project level.
5849 'SYMROOT': '<(DEPTH)/xcodebuild', 5830 'SYMROOT': '<(DEPTH)/xcodebuild',
5850 }, 5831 },
5851 } 5832 }
OLDNEW
« no previous file with comments | « build/asan.saves ('k') | chrome/app/app_asan.saves » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698