Reland https://codereview.chromium.org/292153006 with minor changes.

Reland https://codereview.chromium.org/292153006 (Enable mac_strip_release under ASan on OSX. Remove the .saves files) with minor changes.

Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.

Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).

This CL makes the buildsystem strip only the debug info from the ASan binaries.
As a result, the .saves files aren't necessary anymore.
This CL deletes them and turns mac_strip_release on for ASan
builds.

BUG=148383, 242503, 170739, 166857
TBR=mark@chromium.org

Committed: https://crrev.com/1c2a4917f604903f092bb00afefbd0d5223bd2a8
Cr-Commit-Position: refs/heads/master@{#308976}

[Alexander Potapenko, 2014-12-12 15:25:24]

glider@chromium.org changed reviewers:
+ mark@chromium.org

[Alexander Potapenko, 2014-12-17 13:35:40]

On 2014/12/12 15:25:24, Alexander Potapenko wrote:
> mailto:glider@chromium.org changed reviewers:
> + mailto:mark@chromium.org

Hi Mark,

I'm about to turn on mac_strip_release for ASan builds again.
I've changed https://codereview.chromium.org/292153006 (which you've reviewed
already) a little by removing the -s flag from strip for ASan builds.
Hope you're fine with retaining the symbols in ASan builds.

[Alexander Potapenko, 2014-12-17 13:36:24]

On 2014/12/17 13:35:40, Alexander Potapenko wrote:
> On 2014/12/12 15:25:24, Alexander Potapenko wrote:
> > mailto:glider@chromium.org changed reviewers:
> > + mailto:mark@chromium.org
> 
> Hi Mark,
> 
> I'm about to turn on mac_strip_release for ASan builds again.
> I've changed https://codereview.chromium.org/292153006 (which you've reviewed
> already) a little by removing the -s flag from strip for ASan builds.
> Hope you're fine with retaining the symbols in ASan builds.

This tryjob:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_asan_64/build...
shows that asan_symbolize.py now handles the .dSYM files properly (thanks to
https://codereview.chromium.org/797253002/), which has been broken previously:

==61359==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc
0x00011aa6e8e4 bp 0x7fff530083d0 sp 0x7fff530083d0 T0)
    #0 0x11aa6e8e3 in content::(anonymous namespace)::CrashIntentionally()
/Volumes/data/bool/build/slave/mac_asan_64/build/src/out/Release/../../content/renderer/render_frame_impl.cc:270:3
    #1 0x11aa3cd5c in MaybeHandleDebugURL
/Volumes/data/bool/build/slave/mac_asan_64/build/src/out/Release/../../content/renderer/render_frame_impl.cc:313:5

[Alexander Potapenko, 2014-12-17 13:47:18]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-12-17 13:48:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728233003/100001

[commit-bot: I haz the power, 2014-12-17 13:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 13:54:08]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Alexander Potapenko, 2014-12-17 13:56:10]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-12-17 13:57:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728233003/100001

[Mark Mentovai, 2014-12-17 13:57:39]

LGTM

https://codereview.chromium.org/728233003/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/728233003/diff/100001/build/common.gypi#newco...
build/common.gypi:5103: 'STRIPFLAGS': '-S',
but is this special case for asan even needed anymore?

[Alexander Potapenko, 2014-12-17 13:59:37]

https://codereview.chromium.org/728233003/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/728233003/diff/100001/build/common.gypi#newco...
build/common.gypi:5103: 'STRIPFLAGS': '-S',
On 2014/12/17 13:57:39, Mark Mentovai wrote:
> but is this special case for asan even needed anymore?

Do you mean we can rely on -S being the default? Sure, I'll remove that.

[Alexander Potapenko, 2014-12-17 13:59:44]

The CQ bit was unchecked by glider@chromium.org

[Alexander Potapenko, 2014-12-17 14:00:44]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-12-17 14:01:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728233003/120001

[Mark Mentovai, 2014-12-17 14:06:10]

https://codereview.chromium.org/728233003/diff/120001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/728233003/diff/120001/build/common.gypi#newco...
build/common.gypi:5099: 'STRIPFLAGS': '-x',
Well, yeah, but also, isn’t this -x OK for asan too?

[Alexander Potapenko, 2014-12-17 15:00:08]

The CQ bit was unchecked by glider@chromium.org

[Alexander Potapenko, 2014-12-17 15:24:55]

On 2014/12/17 14:06:10, Mark Mentovai wrote:
> https://codereview.chromium.org/728233003/diff/120001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/728233003/diff/120001/build/common.gypi#newco...
> build/common.gypi:5099: 'STRIPFLAGS': '-x',
> Well, yeah, but also, isn’t this -x OK for asan too?

Looks like it is.
But right now I'm not sure anymore that '-s' isn't being applied to ASan builds,
which we want to avoid (because we're adding a global __asan_default_options
symbol to every binary)
Checking that now

[Alexander Potapenko, 2014-12-17 16:39:03]

On 2014/12/17 15:24:55, Alexander Potapenko wrote:
> On 2014/12/17 14:06:10, Mark Mentovai wrote:
> > https://codereview.chromium.org/728233003/diff/120001/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
>
https://codereview.chromium.org/728233003/diff/120001/build/common.gypi#newco...
> > build/common.gypi:5099: 'STRIPFLAGS': '-x',
> > Well, yeah, but also, isn’t this -x OK for asan too?
> 
> Looks like it is.
> But right now I'm not sure anymore that '-s' isn't being applied to ASan
builds,
> which we want to avoid (because we're adding a global __asan_default_options
> symbol to every binary)
> Checking that now

Looks like strip -x is also ok (PS8).

[Mark Mentovai, 2014-12-17 17:36:00]

LGTM

[Alexander Potapenko, 2014-12-18 08:11:10]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-12-18 08:11:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728233003/140001

[commit-bot: I haz the power, 2014-12-18 09:22:40]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2014-12-18 09:23:46]

Patchset 8 (id:??) landed as
https://crrev.com/1c2a4917f604903f092bb00afefbd0d5223bd2a8
Cr-Commit-Position: refs/heads/master@{#308976}

[Alexander Potapenko, 2014-12-18 10:30:44]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/807813005/ by glider@chromium.org.

The reason for reverting is: Reverting because of NaCl tests breakage
(http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%...)

This probably happened because __asan_default_options got stripped..