Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 728223004: Add string resources for media time sliders. (Closed)

Created:
6 years, 1 month ago by je_julie(Not used)
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add string resources for media time sliders. According to need by Blink, this patch adds new string resource. The related CL https://codereview.chromium.org/729343003/ BUG=431233 Committed: https://crrev.com/a6d98fc3a56b7a5b36d7abac8e75926e51032d0f Cr-Commit-Position: refs/heads/master@{#305356}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/app/strings/content_strings.grd View 1 1 chunk +5 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
je_julie(Not used)
avi and Dominic, This patch adds new string resources to handle AX. PTAL.
6 years, 1 month ago (2014-11-21 10:45:25 UTC) #2
Avi (use Gerrit)
The strings LGTM. As long as dmazzoni is happy with the other stuff..
6 years ago (2014-11-21 15:58:15 UTC) #3
dmazzoni
lgtm Thanks! Could you also remove (or add "deprecated") next to AXMediaSliderHelp in public/platform/WebLocalizedString.h since ...
6 years ago (2014-11-21 16:10:17 UTC) #4
je_julie(Not used)
On 2014/11/21 16:10:17, dmazzoni wrote: > lgtm > > Thanks! > > Could you also ...
6 years ago (2014-11-22 00:53:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728223004/20001
6 years ago (2014-11-22 05:31:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-22 06:24:07 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-22 06:24:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6d98fc3a56b7a5b36d7abac8e75926e51032d0f
Cr-Commit-Position: refs/heads/master@{#305356}

Powered by Google App Engine
This is Rietveld 408576698