Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc

Issue 728133002: Update mojo sdk to rev e01f9a49449381a5eb430c1fd88bf2cae73ec35a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android + ios gyp fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc
diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc
index 91bc26571c44f8dc9cd8c8f63131b254d6193c91..717542309c3f718d51992688c6cc0aea6abe0490 100644
--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc
+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc
@@ -24,9 +24,9 @@ ViewManagerClientFactory::WeakBindViewManagerToPipe(
ScopedMessagePipeHandle handle,
Shell* shell,
ViewManagerDelegate* delegate) {
- scoped_ptr<ViewManagerClientImpl> client(
- new ViewManagerClientImpl(delegate, shell));
- WeakBindToPipe(client.get(), handle.Pass());
+ const bool delete_on_error = false;
+ scoped_ptr<ViewManagerClientImpl> client(new ViewManagerClientImpl(
+ delegate, shell, handle.Pass(), delete_on_error));
return client.Pass();
}
@@ -34,7 +34,9 @@ ViewManagerClientFactory::WeakBindViewManagerToPipe(
void ViewManagerClientFactory::Create(
ApplicationConnection* connection,
InterfaceRequest<ViewManagerClient> request) {
- BindToRequest(new ViewManagerClientImpl(delegate_, shell_), &request);
+ const bool delete_on_error = true;
+ new ViewManagerClientImpl(delegate_, shell_, request.PassMessagePipe(),
+ delete_on_error);
}
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698