Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: mojo/edk/system/channel_endpoint.h

Issue 728133002: Update mojo sdk to rev e01f9a49449381a5eb430c1fd88bf2cae73ec35a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android + ios gyp fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/channel.cc ('k') | mojo/edk/system/channel_endpoint.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/channel_endpoint.h
diff --git a/mojo/edk/system/channel_endpoint.h b/mojo/edk/system/channel_endpoint.h
index 377599d1fc17b1b78ea5628f2f54dfa237d851a3..3c415ea7e6e5347b703c412644f9b8acd0288d8d 100644
--- a/mojo/edk/system/channel_endpoint.h
+++ b/mojo/edk/system/channel_endpoint.h
@@ -26,13 +26,13 @@ class MessagePipe;
// refcounted, and not copyable. Make |Channel| a friend. Make things work.
// - (Done.) Give |ChannelEndpoint| a lock. The lock order (in order of
// allowable acquisition) is: |MessagePipe|, |ChannelEndpoint|, |Channel|.
-// - Stop having |Channel| as a friend.
-// - Move logic from |ProxyMessagePipeEndpoint| into |ChannelEndpoint|. Right
-// now, we have to go through lots of contortions to manipulate state owned
-// by |ProxyMessagePipeEndpoint| (in particular, |Channel::Endpoint| doesn't
-// know about the remote ID; the local ID is duplicated in two places).
-// Hollow out |ProxyMessagePipeEndpoint|, and have it just own a reference
-// to |ChannelEndpoint| (hence the refcounting).
+// - (Done) Stop having |Channel| as a friend.
+// - (Done) Move logic from |ProxyMessagePipeEndpoint| into |ChannelEndpoint|.
+// Right now, we have to go through lots of contortions to manipulate state
+// owned by |ProxyMessagePipeEndpoint| (in particular, |Channel::Endpoint|
+// doesn't know about the remote ID; the local ID is duplicated in two
+// places). Hollow out |ProxyMessagePipeEndpoint|, and have it just own a
+// reference to |ChannelEndpoint| (hence the refcounting).
// - In essence, |ChannelEndpoint| becomes the thing that knows about
// channel-specific aspects of an endpoint (notably local and remote IDs,
// and knowledge about handshaking), and mediates between the |Channel| and
« no previous file with comments | « mojo/edk/system/channel.cc ('k') | mojo/edk/system/channel_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698