| Index: mojo/edk/system/channel_endpoint.h
|
| diff --git a/mojo/edk/system/channel_endpoint.h b/mojo/edk/system/channel_endpoint.h
|
| index 377599d1fc17b1b78ea5628f2f54dfa237d851a3..3c415ea7e6e5347b703c412644f9b8acd0288d8d 100644
|
| --- a/mojo/edk/system/channel_endpoint.h
|
| +++ b/mojo/edk/system/channel_endpoint.h
|
| @@ -26,13 +26,13 @@ class MessagePipe;
|
| // refcounted, and not copyable. Make |Channel| a friend. Make things work.
|
| // - (Done.) Give |ChannelEndpoint| a lock. The lock order (in order of
|
| // allowable acquisition) is: |MessagePipe|, |ChannelEndpoint|, |Channel|.
|
| -// - Stop having |Channel| as a friend.
|
| -// - Move logic from |ProxyMessagePipeEndpoint| into |ChannelEndpoint|. Right
|
| -// now, we have to go through lots of contortions to manipulate state owned
|
| -// by |ProxyMessagePipeEndpoint| (in particular, |Channel::Endpoint| doesn't
|
| -// know about the remote ID; the local ID is duplicated in two places).
|
| -// Hollow out |ProxyMessagePipeEndpoint|, and have it just own a reference
|
| -// to |ChannelEndpoint| (hence the refcounting).
|
| +// - (Done) Stop having |Channel| as a friend.
|
| +// - (Done) Move logic from |ProxyMessagePipeEndpoint| into |ChannelEndpoint|.
|
| +// Right now, we have to go through lots of contortions to manipulate state
|
| +// owned by |ProxyMessagePipeEndpoint| (in particular, |Channel::Endpoint|
|
| +// doesn't know about the remote ID; the local ID is duplicated in two
|
| +// places). Hollow out |ProxyMessagePipeEndpoint|, and have it just own a
|
| +// reference to |ChannelEndpoint| (hence the refcounting).
|
| // - In essence, |ChannelEndpoint| becomes the thing that knows about
|
| // channel-specific aspects of an endpoint (notably local and remote IDs,
|
| // and knowledge about handshaking), and mediates between the |Channel| and
|
|
|