Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: mojo/edk/embedder/test_embedder.cc

Issue 728133002: Update mojo sdk to rev e01f9a49449381a5eb430c1fd88bf2cae73ec35a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android + ios gyp fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/embedder/test_embedder.h ('k') | mojo/edk/js/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/embedder/test_embedder.h" 5 #include "mojo/edk/embedder/test_embedder.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "mojo/edk/embedder/embedder.h" 10 #include "mojo/edk/embedder/embedder.h"
11 #include "mojo/edk/embedder/embedder_internal.h"
11 #include "mojo/edk/embedder/simple_platform_support.h" 12 #include "mojo/edk/embedder/simple_platform_support.h"
13 #include "mojo/edk/system/channel_manager.h"
12 #include "mojo/edk/system/core.h" 14 #include "mojo/edk/system/core.h"
13 #include "mojo/edk/system/entrypoints.h"
14 #include "mojo/edk/system/handle_table.h" 15 #include "mojo/edk/system/handle_table.h"
15 16
16 namespace mojo { 17 namespace mojo {
17 18
18 namespace system { 19 namespace system {
19 namespace internal { 20 namespace internal {
20 21
21 bool ShutdownCheckNoLeaks(Core* core_impl) { 22 bool ShutdownCheckNoLeaks(Core* core) {
22 // No point in taking the lock. 23 // No point in taking the lock.
23 const HandleTable::HandleToEntryMap& handle_to_entry_map = 24 const HandleTable::HandleToEntryMap& handle_to_entry_map =
24 core_impl->handle_table_.handle_to_entry_map_; 25 core->handle_table_.handle_to_entry_map_;
25 26
26 if (handle_to_entry_map.empty()) 27 if (handle_to_entry_map.empty())
27 return true; 28 return true;
28 29
29 for (HandleTable::HandleToEntryMap::const_iterator it = 30 for (HandleTable::HandleToEntryMap::const_iterator it =
30 handle_to_entry_map.begin(); 31 handle_to_entry_map.begin();
31 it != handle_to_entry_map.end(); 32 it != handle_to_entry_map.end(); ++it) {
32 ++it) {
33 LOG(ERROR) << "Mojo embedder shutdown: Leaking handle " << (*it).first; 33 LOG(ERROR) << "Mojo embedder shutdown: Leaking handle " << (*it).first;
34 } 34 }
35 return false; 35 return false;
36 } 36 }
37 37
38 } // namespace internal 38 } // namespace internal
39 } // namespace system 39 } // namespace system
40 40
41 namespace embedder { 41 namespace embedder {
42 namespace test { 42 namespace test {
43 43
44 void InitWithSimplePlatformSupport() { 44 void InitWithSimplePlatformSupport() {
45 Init(make_scoped_ptr(new SimplePlatformSupport())); 45 Init(make_scoped_ptr(new SimplePlatformSupport()));
46 } 46 }
47 47
48 bool Shutdown() { 48 bool Shutdown() {
49 system::Core* core = system::entrypoints::GetCore(); 49 CHECK(internal::g_channel_manager);
50 CHECK(core); 50 delete internal::g_channel_manager;
51 system::entrypoints::SetCore(nullptr); 51 internal::g_channel_manager = nullptr;
52 52
53 bool rv = system::internal::ShutdownCheckNoLeaks(core); 53 CHECK(internal::g_core);
54 delete core; 54 bool rv = system::internal::ShutdownCheckNoLeaks(internal::g_core);
55 delete internal::g_core;
56 internal::g_core = nullptr;
55 return rv; 57 return rv;
56 } 58 }
57 59
58 } // namespace test 60 } // namespace test
59 } // namespace embedder 61 } // namespace embedder
60 62
61 } // namespace mojo 63 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/edk/embedder/test_embedder.h ('k') | mojo/edk/js/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698