Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.cc

Issue 728113002: obsolete: SFI NaCl: Batch-open resource files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/nacl/loader/nacl_ipc_adapter.cc ('K') | « ppapi/c/private/ppb_nacl_private.h ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/plugin.cc
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc
index 7f7e310502961f4b2f6c0453111f83bf73a8eb84..bc29b9668cfc637068ef3c1419dfce288f9fb110 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.cc
+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc
@@ -416,10 +416,6 @@ void Plugin::NaClManifestFileDidOpen(int32_t pp_error) {
// Will always call the callback on success or failure.
nacl_interface_->DownloadNexe(pp_instance(),
program_url.c_str(),
- // pre-open resource files on nonsfi mode
- // TODO(yusukes): Enable the feature for
- // SFI-NaCl too.
- uses_nonsfi_mode,
&nexe_file_info_,
&resource_file_handles_,
&resource_file_handles_len_,
« components/nacl/loader/nacl_ipc_adapter.cc ('K') | « ppapi/c/private/ppb_nacl_private.h ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698