Fix disabling all break points from within the debug event callback.

Fix disabling all break points from within the debug event callback.

BUG=chromium:432493
LOG=Y

Committed: https://chromium.googlesource.com/v8/v8/+/46cd8e6eaaa329435d2b341f1b0595c264251756

[Yang, 2014-11-18 09:04:23]

yangguo@chromium.org changed reviewers:
+ vsevik@chromium.org

[Yang, 2014-11-18 09:04:23]

Please take a look.

[yurys, 2014-11-18 12:53:32]

yurys@chromium.org changed reviewers:
+ yurys@chromium.org

[yurys, 2014-11-18 12:53:33]

lgtm

https://codereview.chromium.org/728103008/diff/1/src/debug.h
File src/debug.h (right):

https://codereview.chromium.org/728103008/diff/1/src/debug.h#newcode598
src/debug.h:598: bool break_disabled_for_event_;
I'd rather call it something like in_debug_listener_ which would better reflect
current state.

https://codereview.chromium.org/728103008/diff/1/src/debug.h#newcode722
src/debug.h:722: bool previous_break_disabled_ : 1;
Does it really make sense to use bit fields here? To my taste they just distract
reader of the code.

[aandrey, 2014-11-18 14:07:27]

aandrey@chromium.org changed reviewers:
+ aandrey@chromium.org

[aandrey, 2014-11-18 14:07:27]

lgtm

https://codereview.chromium.org/728103008/diff/1/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-crbug-432493.js (right):

https://codereview.chromium.org/728103008/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-crbug-432493.js:41: 
mind adding assertEquals(1, break_count); here?

[Yang, 2014-11-18 14:30:02]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2014-11-18 14:30:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/728103008/20001

[commit-bot: I haz the power, 2014-11-18 14:57:44]

Committed patchset #2 (id:20001)