Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 728013002: Fix Android framework build. (Closed)

Created:
6 years, 1 month ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
djsollen, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix Android framework build. When we define SK_BUILD_FOR_ANDROID, we don't define it to anything, so #if SK_BUILD_FOR_ANDROID is not a meaningful check. Instead, use #ifdef. TBR=caryclark@google.com, djsollen@google.com Committed: https://skia.googlesource.com/skia/+/28562a01999d49abcbd60abbfba06f2ac8046f6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/PathOpsFuzz763Test.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scroggo
6 years, 1 month ago (2014-11-14 22:34:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728013002/1
6 years, 1 month ago (2014-11-14 22:34:36 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 22:49:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/28562a01999d49abcbd60abbfba06f2ac8046f6d

Powered by Google App Engine
This is Rietveld 408576698