Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 7280007: Merge 90013 - 2011-06-29 Pavel Feldman <pfeldman@google.com> (Closed)

Created:
9 years, 8 months ago by loislo
Modified:
9 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, laforge
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 90013 - 2011-06-29 Pavel Feldman <pfeldman@google.com>; Reviewed by Yury Semikhatsky. Web Inspector: tab crash after deleting trailing quote when editing attribute https://bugs.webkit.org/show_bug.cgi?id=63544 * inspector/elements/set-attribute-expected.txt: * inspector/elements/set-attribute.html: 2011-06-29 Pavel Feldman <pfeldman@google.com>; Reviewed by Yury Semikhatsky. Web Inspector: tab crash after deleting trailing quote when editing attribute https://bugs.webkit.org/show_bug.cgi?id=63544 * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setAttributesText): * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): TBR=pfeldman@chromium.org BUG=87895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M LayoutTests/inspector/elements/set-attribute.html View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorDOMAgent.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/ElementsTreeOutline.js View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
loislo
9 years, 8 months ago (2011-06-29 14:28:42 UTC) #1
loislo
9 years, 8 months ago (2011-06-29 14:29:13 UTC) #2
laforge
9 years, 8 months ago (2011-06-29 15:12:18 UTC) #3
LGTM

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA


On Wed, Jun 29, 2011 at 7:29 AM, <loislo@chromium.org> wrote:

>
http://codereview.chromium.**org/7280007/<http://codereview.chromium.org/7280...
>

Powered by Google App Engine
This is Rietveld 408576698