Move some parts of ProcessReader (in snapshot) to ProcessInfo (in util)

util/posix/process_info_test.cc

Index: util/posix/process_info_test.cc
diff --git a/util/posix/process_info_test.cc b/util/posix/process_info_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7ddac2adbd409e0ab73b388d49da8d0c92608c83
--- /dev/null
+++ b/util/posix/process_info_test.cc
@@ -0,0 +1,140 @@
+// Copyright 2014 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/posix/process_info.h"
+
+#include <crt_externs.h>
+#include <time.h>
+#include <unistd.h>
+
+#include <set>
+#include <string>
+#include <vector>
+
+#include "base/basictypes.h"
+#include "build/build_config.h"
+#include "gtest/gtest.h"
+#include "util/test/errors.h"
+
+namespace crashpad {
+namespace test {
+namespace {
+
+void TestSelfProcess(const ProcessInfo& process_info) {
+  EXPECT_EQ(getpid(), process_info.ProcessID());
+  EXPECT_EQ(getppid(), process_info.ParentProcessID());
+
+  // There’s no system call to obtain the saved set-user ID or saved set-group
+  // ID in an easy way. Normally, they are the same as the effective user ID and
+  // effective group ID, so just check against those.
+  EXPECT_EQ(getuid(), process_info.RealUserID());
+  const uid_t euid = geteuid();
+  EXPECT_EQ(euid, process_info.EffectiveUserID());
+  EXPECT_EQ(euid, process_info.SavedUserID());
+  const gid_t gid = getgid();
+  EXPECT_EQ(gid, process_info.RealGroupID());
+  const gid_t egid = getegid();
+  EXPECT_EQ(egid, process_info.EffectiveGroupID());
+  EXPECT_EQ(egid, process_info.SavedGroupID());
+
+  // Test SupplementaryGroups().
+  int group_count = getgroups(0, nullptr);
+  ASSERT_GE(group_count, 0) << ErrnoMessage("getgroups");
+
+  std::vector<gid_t> group_vector(group_count);
+  if (group_count > 0) {
+    group_count = getgroups(group_vector.size(), &group_vector[0]);
+    ASSERT_GE(group_count, 0) << ErrnoMessage("getgroups");
+    ASSERT_EQ(group_vector.size(), implicit_cast<size_t>(group_count));
+  }
+
+  std::set<gid_t> group_set(group_vector.begin(), group_vector.end());
+  EXPECT_EQ(group_set, process_info.SupplementaryGroups());
+
+  // Test AllGroups(), which is SupplementaryGroups() plus the real, effective,
+  // and saved set-group IDs. The effective and saved set-group IDs are expected
+  // to be identical (see above).
+  group_set.insert(gid);
+  group_set.insert(egid);
+
+  EXPECT_EQ(group_set, process_info.AllGroups());
+
+  // The test executable isn’t expected to change privileges.
+  EXPECT_FALSE(process_info.DidChangePrivileges());
+
+#if defined(ARCH_CPU_64_BITS)
+  EXPECT_TRUE(process_info.Is64Bit());
+#else
+  EXPECT_FALSE(process_info.Is64Bit());
+#endif
+
+  // Test StartTime(). This program must have started at some time in the past.
+  timeval start_time;
+  process_info.StartTime(&start_time);
+  time_t now;
+  time(&now);
+  EXPECT_LE(start_time.tv_sec, now);
+
+  std::vector<std::string> argv;
+  ASSERT_TRUE(process_info.Arguments(&argv));
+
+  // gtest argv processing scrambles argv, but it leaves argc and argv[0]
+  // intact, so test those.
+
+  int argc = implicit_cast<int>(argv.size());
+  int expect_argc = *_NSGetArgc();

[Robert Sesek, 2014/11/14 22:06:18]

This isn't quite POSIX-y.

+  EXPECT_EQ(expect_argc, argc);
+
+  ASSERT_GE(expect_argc, 1);
+  ASSERT_GE(argc, 1);
+
+  char** expect_argv = *_NSGetArgv();
+  EXPECT_EQ(std::string(expect_argv[0]), argv[0]);
+}
+
+
+TEST(ProcessInfo, Self) {
+  ProcessInfo process_info;
+  ASSERT_TRUE(process_info.Initialize(getpid()));
+  TestSelfProcess(process_info);
+}
+
+#if defined(OS_MACOSX)
+TEST(ProcessInfo, SelfTask) {
+  ProcessInfo process_info;
+  ASSERT_TRUE(process_info.InitializeFromTask(mach_task_self()));
+  TestSelfProcess(process_info);
+}
+#endif
+
+TEST(ProcessInfo, Pid1) {
+  // PID 1 is expected to be init or the system’s equivalent. This tests reading
+  // information about another process.
+  ProcessInfo process_info;
+  ASSERT_TRUE(process_info.Initialize(1));
+
+  EXPECT_EQ(implicit_cast<pid_t>(1), process_info.ProcessID());
+  EXPECT_EQ(implicit_cast<pid_t>(0), process_info.ParentProcessID());
+  EXPECT_EQ(implicit_cast<uid_t>(0), process_info.RealUserID());
+  EXPECT_EQ(implicit_cast<uid_t>(0), process_info.EffectiveUserID());
+  EXPECT_EQ(implicit_cast<uid_t>(0), process_info.SavedUserID());
+  EXPECT_EQ(implicit_cast<gid_t>(0), process_info.RealGroupID());
+  EXPECT_EQ(implicit_cast<gid_t>(0), process_info.EffectiveGroupID());
+  EXPECT_EQ(implicit_cast<gid_t>(0), process_info.SavedGroupID());
+  EXPECT_FALSE(process_info.AllGroups().empty());
+}
+
+}  // namespace
+}  // namespace test
+}  // namespace crashpad