app_shell: Change flag for loading apps to --load-app and only launch

app_shell: Change flag for loading apps to --load-app and only launch
the first one.

BUG=432359
Committed: https://crrev.com/62c0f69893232578d8d5d5ecf9b1374f24c404bd
Cr-Commit-Position: refs/heads/master@{#304500}

[Zachary Kuznia, 2014-11-14 22:34:15]

zork@chromium.org changed reviewers:
+ derat@chromium.org

[Zachary Kuznia, 2014-11-14 22:34:16]

Please take a look

[Daniel Erat, 2014-11-14 22:43:32]

https://codereview.chromium.org/727963004/diff/1/extensions/common/switches.cc
File extensions/common/switches.cc (right):

https://codereview.chromium.org/727963004/diff/1/extensions/common/switches.c...
extensions/common/switches.cc:81: // Path to a apps to load at startup.
nit: "Path to a comma-separated list of apps to load at startup."?

https://codereview.chromium.org/727963004/diff/1/extensions/common/switches.c...
extensions/common/switches.cc:82: const char kLoadApp[] = "load-app";
kLoadApps / load-apps since it takes more than one?

[Zachary Kuznia, 2014-11-14 22:54:48]

https://codereview.chromium.org/727963004/diff/1/extensions/common/switches.cc
File extensions/common/switches.cc (right):

https://codereview.chromium.org/727963004/diff/1/extensions/common/switches.c...
extensions/common/switches.cc:81: // Path to a apps to load at startup.
On 2014/11/14 22:43:32, Daniel Erat wrote:
> nit: "Path to a comma-separated list of apps to load at startup."?

Done.

https://codereview.chromium.org/727963004/diff/1/extensions/common/switches.c...
extensions/common/switches.cc:82: const char kLoadApp[] = "load-app";
On 2014/11/14 22:43:32, Daniel Erat wrote:
> kLoadApps / load-apps since it takes more than one?

Done.

[Daniel Erat, 2014-11-14 23:08:45]

lgtm with a few comments

https://codereview.chromium.org/727963004/diff/20001/extensions/common/switch...
File extensions/common/switches.cc (right):

https://codereview.chromium.org/727963004/diff/20001/extensions/common/switch...
extensions/common/switches.cc:81: // Path to a comma-separated list of apps to
load at startup.
sorry, my previous suggestion was bad. i meant:

  // Comma-separated list of paths of apps to load at startup.

i'd also add a second sentence like this:

  // The first app in the list will be launched.

https://codereview.chromium.org/727963004/diff/20001/extensions/shell/README
File extensions/shell/README (right):

https://codereview.chromium.org/727963004/diff/20001/extensions/shell/README#...
extensions/shell/README:13: $ app_shell --load-app=/path/to/extension
update this example and the other one to --load-apps

[Zachary Kuznia, 2014-11-14 23:14:43]

https://codereview.chromium.org/727963004/diff/20001/extensions/common/switch...
File extensions/common/switches.cc (right):

https://codereview.chromium.org/727963004/diff/20001/extensions/common/switch...
extensions/common/switches.cc:81: // Path to a comma-separated list of apps to
load at startup.
On 2014/11/14 23:08:45, Daniel Erat wrote:
> sorry, my previous suggestion was bad. i meant:
> 
>   // Comma-separated list of paths of apps to load at startup.
> 
> i'd also add a second sentence like this:
> 
>   // The first app in the list will be launched.

Done.

https://codereview.chromium.org/727963004/diff/20001/extensions/shell/README
File extensions/shell/README (right):

https://codereview.chromium.org/727963004/diff/20001/extensions/shell/README#...
extensions/shell/README:13: $ app_shell --load-app=/path/to/extension
On 2014/11/14 23:08:45, Daniel Erat wrote:
> update this example and the other one to --load-apps

Done.

[Zachary Kuznia, 2014-11-14 23:15:17]

zork@chromium.org changed reviewers:
+ yoz@chromium.org

[Zachary Kuznia, 2014-11-14 23:15:18]

Hi Yoyo,

Could you do an OWNERS review of this?

Thanks,
-Zach

[Yoyo Zhou, 2014-11-14 23:19:38]

James or Ken: why did we make the flag name the verbose --app-shell-app-path?

[Daniel Erat, 2014-11-14 23:21:07]

my fault, i think. the app_shell code was pretty disjoint from chrome's startup
code at the time and i have a preference for naming flags so it's clear which
module they're affecting.

[Yoyo Zhou, 2014-11-14 23:21:29]

ok, LGTM

https://codereview.chromium.org/727963004/diff/40001/extensions/shell/README
File extensions/shell/README (right):

https://codereview.chromium.org/727963004/diff/40001/extensions/shell/README#...
extensions/shell/README:11: # How to run
Should there be another section in here giving a comma-separated example?

[Zachary Kuznia, 2014-11-14 23:22:04]

On 2014/11/14 23:19:38, Yoyo Zhou wrote:
> James or Ken: why did we make the flag name the verbose --app-shell-app-path?

There's a follow-up CL to this that adds this flag to Chrome as well:
https://codereview.chromium.org/718133005/

[Zachary Kuznia, 2014-11-14 23:26:20]

https://codereview.chromium.org/727963004/diff/40001/extensions/shell/README
File extensions/shell/README (right):

https://codereview.chromium.org/727963004/diff/40001/extensions/shell/README#...
extensions/shell/README:11: # How to run
On 2014/11/14 23:21:29, Yoyo Zhou wrote:
> Should there be another section in here giving a comma-separated example?

Done.

[Zachary Kuznia, 2014-11-14 23:40:45]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-11-14 23:42:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727963004/60001

[commit-bot: I haz the power, 2014-11-15 00:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-15 00:11:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zachary Kuznia, 2014-11-17 21:31:50]

zork@chromium.org changed reviewers:
+ oshima@chromium.org

[Zachary Kuznia, 2014-11-17 21:31:50]

oshima: Could you do an OWNERS review of athena/*?

[oshima, 2014-11-17 21:41:26]

athena lgtm

[Zachary Kuznia, 2014-11-17 21:46:14]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-11-17 21:47:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727963004/80001

[commit-bot: I haz the power, 2014-11-17 22:41:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-17 22:41:43]

Patchset 5 (id:??) landed as
https://crrev.com/62c0f69893232578d8d5d5ecf9b1374f24c404bd
Cr-Commit-Position: refs/heads/master@{#304500}