Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 727933002: Remove FINAL macro to make chromium presubmit happy (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M sky/engine/platform/weborigin/KURL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/EditorClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/GraphicsLayerFactoryChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/LinkHighlight.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/SpellCheckerClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebFontImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebLeakDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebTextCheckingCompletionImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/wtf/FilePrintStream.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Float32Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Float64Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Int16Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Int32Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Int8Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/TypedArrayBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/wtf/Uint16Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Uint32Array.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/Uint8ClampedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/TextCodecICU.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/TextCodecLatin1.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/TextCodecReplacement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/TextCodecUTF16.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/wtf/text/TextCodecUserDefined.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eseidel
6 years, 1 month ago (2014-11-14 20:55:25 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
40ee4c7c11d9de4c1bafd82f4132bd26be59fcf2.

Powered by Google App Engine
This is Rietveld 408576698