ComponentCloudPolicyService tracks the signin state.

ComponentCloudPolicyService tracks the signin state.

The ComponentCloudPolicyService is used to fetch policy for Chrome components
such as extensions. This change makes it follow the sign-in state by observing
the cloud policy store and a cloud policy core, which determine that state
from the cloud policy system perspective.

The component policy cache will be cleared on signout.

The ComponentCloudPolicyService now tracks a CloudPolicyCore to determine
whether a CloudPolicyClient is available or not; it is possible to signin
and signout multiple times.

BUG=108992
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235747

[Joao da Silva, 2013-11-17 20:11:51]

It's the last of the big ones, and not that big :-) PTAL, thanks!

[bartfab (slow), 2013-11-18 13:15:39]

lgtm

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service.cc (right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.cc:15: #include
"base/time/time.h"
Nit: No longer used.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.cc:361: // if
OnPolicyFetched() sent the PolicyFetchResponses to the backend then
I see what you are trying to say but the sentence does not parse well. Could you
split the long sentence into two and replace ambiguous phrases like then (do you
mean "if ... then" or "there and then" - two very different meanings of the
word)?

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service.h (right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.h:154: // can go back
to false if the user signs out, and back again to true if he
Nit: s/he/he or she/ or s/he/the user/ or, if you do not mind bending English
grammar a bit, s/he signs/they sign/

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc
(right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc:495:
std::map<std::string, std::string> contents;
Nit 1: #include <map>
Nit 2: #include <string>

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc:499: //
Now signin.
Nit: s/signin/sign in/.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_store.cc (right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_store.cc:235: const
std::set<std::string> empty;
Nit: Not used.

[Joao da Silva, 2013-11-18 14:54:18]

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service.cc (right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.cc:15: #include
"base/time/time.h"
On 2013/11/18 13:15:39, bartfab wrote:
> Nit: No longer used.

Done.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.cc:361: // if
OnPolicyFetched() sent the PolicyFetchResponses to the backend then
On 2013/11/18 13:15:39, bartfab wrote:
> I see what you are trying to say but the sentence does not parse well. Could
you
> split the long sentence into two and replace ambiguous phrases like then (do
you
> mean "if ... then" or "there and then" - two very different meanings of the
> word)?

Done.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service.h (right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.h:154: // can go back
to false if the user signs out, and back again to true if he
On 2013/11/18 13:15:39, bartfab wrote:
> Nit: s/he/he or she/ or s/he/the user/ or, if you do not mind bending English
> grammar a bit, s/he signs/they sign/

Done.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc
(right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc:495:
std::map<std::string, std::string> contents;
On 2013/11/18 13:15:39, bartfab wrote:
> Nit 1: #include <map>
> Nit 2: #include <string>

Done.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc:499: //
Now signin.
On 2013/11/18 13:15:39, bartfab wrote:
> Nit: s/signin/sign in/.

Done.

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_store.cc (right):

https://codereview.chromium.org/72793003/diff/50001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_store.cc:235: const
std::set<std::string> empty;
On 2013/11/18 13:15:39, bartfab wrote:
> Nit: Not used.

Eh, what is this doing here :-) Done

[commit-bot: I haz the power, 2013-11-18 14:54:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/72793003/280001

[commit-bot: I haz the power, 2013-11-18 16:52:47]

Change committed as 235747