update-w3c-deps import using blink 7f8c8ee3e30dc15b7b821c627fc7ac32331d2253:

update-w3c-deps import using blink 7f8c8ee3e30dc15b7b821c627fc7ac32331d2253:

imported csswg-test@7f8c8ee3e30dc15b7b821c627fc7ac32331d2253
imported web-platform-tests@7f8c8ee3e30dc15b7b821c627fc7ac32331d2253

Pull in new IndexedDB and encoding tests. Also fix
a glitch in w3c/test_importer.py stopping it from
excluding files, and clean up the fallout from that.

R=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185556

[jsbell, 2014-11-14 18:30:48]

dpranke@ - please take a look?

I just ran:

 Tools/Scripts/update-w3c-deps

And generated/added:


LayoutTests/imported/web-platform-tests/encoding/iso-2022-jp-decoder-expected.txt

(crbug.com/277062)

[Dirk Pranke, 2014-11-14 18:35:29]

lgtm.

What you've done is fine, but I'd probably add lines to the
W3CImportExpectations to skip serve.py and the docs/ directory, unless you
thought it was useful to keep them around.

[jsbell, 2014-11-14 18:50:33]

> What you've done is fine, but I'd probably add lines to the
> W3CImportExpectations to skip serve.py and the docs/ directory, unless you
> thought it was useful to keep them around.

Will do, wasn't sure whether we leaned towards inclusion or exclusion.

Heh... there's already an entry for:

imported/web-platform-tests/serve.py [ Skip ]

Looks like it was added before it was blacklisted. I'll see about whacking it.

[jsbell, 2014-11-14 19:12:41]

Weird... a bunch of files marked [ Skip ] are present. Deleting serve.py then
re-running the import restores it. Something busted in test_importer.py ?

[Dirk Pranke, 2014-11-14 20:33:53]

On 2014/11/14 19:12:41, jsbell wrote:
> Weird... a bunch of files marked [ Skip ] are present. Deleting serve.py then
> re-running the import restores it. Something busted in test_importer.py ?

Could be. The file-parsing logic is stupid (we're not using the normal
expectation-parsing code), so there could be a bug. I'll take a look.

[jsbell, 2014-11-14 20:58:33]

On 2014/11/14 20:33:53, Dirk Pranke wrote:
> On 2014/11/14 19:12:41, jsbell wrote:
> > Weird... a bunch of files marked [ Skip ] are present. Deleting serve.py
then
> > re-running the import restores it. Something busted in test_importer.py ?
> 
> Could be. The file-parsing logic is stupid (we're not using the normal
> expectation-parsing code), so there could be a bug. I'll take a look.

Yeah, the path_base calculation in the "for filename in files" block is bogus,
since path_full is outside of self.layout_tests_dir 

                 path_full = self.filesystem.join(root, filename)
-                path_base = path_full.replace(self.layout_tests_dir + '/', '')
+                path_base = path_full.replace(directory + '/', '')
+                path_base = self.options.destination + '/' + path_base

[jsbell, 2014-11-14 21:49:57]

On 2014/11/14 20:58:33, jsbell wrote:
>                  path_full = self.filesystem.join(root, filename)
> -                path_base = path_full.replace(self.layout_tests_dir + '/',
'')
> +                path_base = path_full.replace(directory + '/', '')
> +                path_base = self.options.destination + '/' + path_base

Whoops, still missing something in the path, sorry. Fooled myself into thinking
that was working.

[jsbell, 2014-11-14 22:21:07]

There we go. This also cleans up files that should have been removed with [ Skip
]. Not sure why rietveld is showing them as 'M' to an empty file rather than
'D'....

[Dirk Pranke, 2014-11-14 22:23:33]

lgtm.

Agreed that the 'M' is a bit odd ... I guess we'll see if it lands properly.

[jsbell, 2014-11-15 00:01:25]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2014-11-15 00:01:35]

I have no idea why the bots are failing on the
custom-elements-type-allowed-chars tests - there are explicit [Failure] lines in
TestExpectations for those which cause the failures to be ignored when I run
them locally.

Trying to commit for fun...

[commit-bot: I haz the power, 2014-11-15 00:13:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727883002/40001

[commit-bot: I haz the power, 2014-11-15 01:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-15 01:36:45]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[jsbell, 2014-11-18 19:31:44]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-11-18 19:32:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727883002/80001

[commit-bot: I haz the power, 2014-11-18 20:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-18 20:08:47]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/37108)

[jsbell, 2014-11-18 20:16:30]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-11-18 20:16:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727883002/80001

[commit-bot: I haz the power, 2014-11-18 20:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-18 20:51:05]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/37124)

[jsbell, 2014-11-18 22:56:57]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-11-18 22:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727883002/80001

[commit-bot: I haz the power, 2014-11-18 23:41:52]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185556