Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: Source/devtools/front_end/sources/NavigatorView.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 10 *
(...skipping 1283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1294 WebInspector.markBeingEdited(treeOutlineElement, false); 1294 WebInspector.markBeingEdited(treeOutlineElement, false);
1295 this.updateTitle(); 1295 this.updateTitle();
1296 this._treeElement.treeOutline.childrenListElement.focus(); 1296 this._treeElement.treeOutline.childrenListElement.focus();
1297 if (callback) 1297 if (callback)
1298 callback(committed); 1298 callback(committed);
1299 } 1299 }
1300 1300
1301 var editingConfig = new WebInspector.InplaceEditor.Config(commitHandler. bind(this), cancelHandler.bind(this)); 1301 var editingConfig = new WebInspector.InplaceEditor.Config(commitHandler. bind(this), cancelHandler.bind(this));
1302 this.updateTitle(true); 1302 this.updateTitle(true);
1303 WebInspector.InplaceEditor.startEditing(this._treeElement.titleElement, editingConfig); 1303 WebInspector.InplaceEditor.startEditing(this._treeElement.titleElement, editingConfig);
1304 window.getSelection().setBaseAndExtent(this._treeElement.titleElement, 0 , this._treeElement.titleElement, 1); 1304 treeOutlineElement.window().getSelection().setBaseAndExtent(this._treeEl ement.titleElement, 0, this._treeElement.titleElement, 1);
1305 }, 1305 },
1306 1306
1307 __proto__: WebInspector.NavigatorTreeNode.prototype 1307 __proto__: WebInspector.NavigatorTreeNode.prototype
1308 } 1308 }
1309 1309
1310 /** 1310 /**
1311 * @constructor 1311 * @constructor
1312 * @extends {WebInspector.NavigatorTreeNode} 1312 * @extends {WebInspector.NavigatorTreeNode}
1313 * @param {!WebInspector.NavigatorView} navigatorView 1313 * @param {!WebInspector.NavigatorView} navigatorView
1314 * @param {?WebInspector.Project} project 1314 * @param {?WebInspector.Project} project
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
1443 1443
1444 willRemoveChild: function(node) 1444 willRemoveChild: function(node)
1445 { 1445 {
1446 if (node._isMerged || !this.isPopulated()) 1446 if (node._isMerged || !this.isPopulated())
1447 return; 1447 return;
1448 this._treeElement.removeChild(node._treeElement); 1448 this._treeElement.removeChild(node._treeElement);
1449 }, 1449 },
1450 1450
1451 __proto__: WebInspector.NavigatorTreeNode.prototype 1451 __proto__: WebInspector.NavigatorTreeNode.prototype
1452 } 1452 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698