Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 727783004: Fix Chromium roll broken by http://crrev.com/728823002 (Closed)

Created:
6 years, 1 month ago by hal.canary
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : compile everywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A include/utils/SkWGL.h View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hal.canary
PTAL
6 years, 1 month ago (2014-11-14 22:03:03 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-14 22:12:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727783004/1
6 years, 1 month ago (2014-11-14 22:13:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/723) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/698) Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot ...
6 years, 1 month ago (2014-11-14 22:15:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727783004/20001
6 years, 1 month ago (2014-11-15 01:14:22 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 01:22:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6dd03c899f7685ccde40017207bdabf55d2c866a

Powered by Google App Engine
This is Rietveld 408576698