Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 727733002: [turbofan] refactor pipeline to use hydrogen like Run calls (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] refactor pipeline to use hydrogen like Run calls BUG= Committed: https://chromium.googlesource.com/v8/v8/+/2738466f3b60009d835129090434e9b66211acaa

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : fixes #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -306 lines) Patch
M src/compiler/ast-graph-builder.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/frame.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/instruction.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/pipeline.h View 1 2 3 4 5 1 chunk +15 lines, -7 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 5 16 chunks +474 lines, -279 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 4 5 6 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
https://codereview.chromium.org/727733002/diff/60001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/727733002/diff/60001/src/compiler/pipeline.cc#newcode258 src/compiler/pipeline.cc:258: void Run(PipelineData* data) { I like this a lot ...
6 years, 1 month ago (2014-11-14 14:03:40 UTC) #2
dcarney
more, ptal
6 years, 1 month ago (2014-11-14 15:48:46 UTC) #3
titzer
https://codereview.chromium.org/727733002/diff/100001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/727733002/diff/100001/src/compiler/pipeline.cc#newcode330 src/compiler/pipeline.cc:330: static const char* phase_name() { return "graph builder"; } ...
6 years, 1 month ago (2014-11-14 16:07:47 UTC) #4
titzer
lgtm
6 years, 1 month ago (2014-11-14 16:13:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727733002/140001
6 years, 1 month ago (2014-11-14 16:17:15 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 16:44:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #8 (id:140001)

Powered by Google App Engine
This is Rietveld 408576698