Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 727673003: Add XFA files to GN build. (Closed)

Created:
6 years, 1 month ago by Tom Sepez
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
pdfium-reviews_googlegroups.com, Bo Xu, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Visibility:
Public.

Description

Add XFA files to GN build. This mirrors the changes made to .gyp files on the XFA branch. Chrome is still building against the master branch, so the only meaningful way to test this is locally. R=dpranke@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c706fc0cc47510bd51a107dabf7dd19bc821f360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+750 lines, -1 line) Patch
M BUILD.gn View 7 chunks +750 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Dirk, please review.
6 years, 1 month ago (2014-11-14 21:23:41 UTC) #2
Dirk Pranke
lgtm
6 years, 1 month ago (2014-11-14 21:38:07 UTC) #3
Tom Sepez
6 years, 1 month ago (2014-11-14 21:39:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c706fc0cc47510bd51a107dabf7dd19bc821f360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698