Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: test/mjsunit/asm/int32mod.js

Issue 727673002: [turbofan] Optimize remainder of integer division by unknown power of two. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix broken Int32Mod on ARM Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | test/mjsunit/asm/int32mod-constant.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/asm/int32mod.js
diff --git a/test/mjsunit/asm/int32mod.js b/test/mjsunit/asm/int32mod.js
index ec3e887ce4408aabb191f2dccab575c73a90070a..22fa81384d49af081f32a3a78b51cebf26d4dee8 100644
--- a/test/mjsunit/asm/int32mod.js
+++ b/test/mjsunit/asm/int32mod.js
@@ -6,28 +6,21 @@ var stdlib = {};
var foreign = {};
var heap = new ArrayBuffer(64 * 1024);
-function Int32Mod(divisor) {
- var name = "mod_";
- if (divisor < 0) {
- name += "minus_";
+var mod = (function Module(stdlib, foreign, heap) {
+ "use asm";
+ function mod(dividend, divisor) {
+ dividend = dividend|0;
+ divisor = divisor|0;
+ return (dividend % divisor) | 0;
}
- name += Math.abs(divisor);
- var m = eval("function Module(stdlib, foreign, heap) {\n"
- + " \"use asm\";\n"
- + " function " + name + "(dividend) {\n"
- + " return ((dividend | 0) % " + divisor + ") | 0;\n"
- + " }\n"
- + " return { f: " + name + "}\n"
- + "}; Module");
- return m(stdlib, foreign, heap).f;
-}
+ return { mod: mod };
+})(stdlib, foreign, heap).mod;
-var divisors = [-2147483648, -32 * 1024, -1000, -16, -7, -2, -1,
+var divisors = [-2147483648, -32 * 1024, -1000, -16, -7, -2, -1, 0,
1, 3, 4, 10, 64, 100, 1024, 2147483647];
for (var i in divisors) {
var divisor = divisors[i];
- var mod = Int32Mod(divisor);
for (var dividend = -2147483648; dividend < 2147483648; dividend += 3999773) {
- assertEquals((dividend % divisor) | 0, mod(dividend));
+ assertEquals((dividend % divisor) | 0, mod(dividend, divisor));
}
}
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | test/mjsunit/asm/int32mod-constant.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698