Issue 7276045: Give a CFRunLoop to the IO message loop type on Mac OS X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7276045: Give a CFRunLoop to the IO message loop type on Mac OS X.

Created:
9 years, 5 months ago by wtc

Modified:
7 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, TVL

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Give a CFRunLoop to the IO message loop type on Mac OS X. This requires using CFFileDescriptor instead of libevent to monitor IO events. This removes the dependency on libevent. R=mark@chromium.org BUG=? TEST=base_unittests, ipc_unittests, and net_unittests should pass

Patch Set 1 #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+385 lines, -23 lines)			Patch
M	base/base.gyp	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	base/base.gypi	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	base/message_loop.h	View	6 chunks	+29 lines, -3 lines	0 comments	Download
M	base/message_loop.cc	View	3 chunks	+17 lines, -4 lines	1 comment	Download
M	base/message_pump_mac.h	View	4 chunks	+109 lines, -0 lines	0 comments	Download
M	base/message_pump_mac.mm	View	4 chunks	+199 lines, -0 lines	0 comments	Download
A +	base/message_pump_mac_unittest.cc	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	build/all.gyp	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

9 years, 5 months ago (2011-06-29 01:21:21 UTC) #1

I can still review the remainder of the changes if you’re interested in pursuing
this configuration as an option, but I’m not interested in changing the default
IO loop type at this time.

If you’re interested in pursuing that, can you upload a version of this change
that doesn’t change the default IO loop type for the Mac?

http://codereview.chromium.org/7276045/diff/1/base/message_loop.cc
File base/message_loop.cc (right):

http://codereview.chromium.org/7276045/diff/1/base/message_loop.cc#newcode177
base/message_loop.cc:177: #define MESSAGE_PUMP_IO base::MessagePumpMac::Create()
As I mentioned last week, I don’t really want to make this the default IO pump
type on the Mac. It’s more important to me to share the IO loop with Linux.

Expand Messages | Collapse Messages