Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/ssl/ssl_manager.h

Issue 7276: Adding security info to canceled requests (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_manager.h
===================================================================
--- chrome/browser/ssl/ssl_manager.h (revision 9948)
+++ chrome/browser/ssl/ssl_manager.h (working copy)
@@ -49,6 +49,8 @@
class SSLManager : public NotificationObserver {
public:
+ class CertError;
+
// An ErrorHandler carries information from the IO thread to the UI thread
// and is dispatched to the appropriate SSLManager when it arrives on the
// UI thread. Subclasses should override the OnDispatched/OnDispatchFailed
@@ -63,6 +65,8 @@
public:
virtual ~ErrorHandler() { }
+ virtual CertError* AsCertError() { return NULL; }
+
// Find the appropriate SSLManager for the URLRequest and begin handling
// this error.
//
@@ -167,7 +171,7 @@
bool request_has_been_notified_; // A flag to make sure we notify the
// URLRequest exactly once.
- DISALLOW_EVIL_CONSTRUCTORS(ErrorHandler);
+ DISALLOW_COPY_AND_ASSIGN(ErrorHandler);
};
// A CertError represents an error that occurred with the certificate in an
@@ -175,6 +179,9 @@
// thread and allows us to cancel/continue a request it is associated with.
class CertError : public ErrorHandler {
public:
+
+ virtual CertError* AsCertError() { return this; }
+
// These accessors are available on either thread
const net::SSLInfo& ssl_info() const { return ssl_info_; }
int cert_error() const { return cert_error_; }
@@ -206,7 +213,7 @@
// that error.
ResourceType::Type resource_type_;
- DISALLOW_EVIL_CONSTRUCTORS(CertError);
+ DISALLOW_COPY_AND_ASSIGN(CertError);
};
// The MixedContentHandler class is used to query what to do with
@@ -224,7 +231,7 @@
virtual void OnDispatched() { manager()->OnMixedContent(this); }
private:
- DISALLOW_EVIL_CONSTRUCTORS(MixedContentHandler);
+ DISALLOW_COPY_AND_ASSIGN(MixedContentHandler);
};
// The SSLManager will ask its delegate to decide how to handle events

Powered by Google App Engine
This is Rietveld 408576698