Adding security info to canceled requests

webkit/glue/resource_loader_bridge.h

Index: webkit/glue/resource_loader_bridge.h
===================================================================
--- webkit/glue/resource_loader_bridge.h	(revision 9948)
+++ webkit/glue/resource_loader_bridge.h	(working copy)
@@ -91,7 +91,8 @@
 
     // Called when the response is complete.  This method signals completion of
     // the resource load.
-    virtual void OnCompletedRequest(const URLRequestStatus& status) = 0;
+    virtual void OnCompletedRequest(const URLRequestStatus& status,
+                                    const std::string& security_info) = 0;

[darin (slow to review), 2009/03/04 19:29:01]

so, iirc, we echo the security_info here in case OnReceivedResponse was not
called?  and that only happens in the case of an error, right?

[jcampan, 2009/03/04 22:33:43]

That's right, if the load of a resource failed we only get that call. The
provided security info can be used by the security filter peer and attached to
content they create. This is the case with sub-frames, if a sub-frame fails to
load because of a SSL error we replace it with some HTML showing an error. Since
now we attach the ssl info, the bad cert will be viewable for that frame.
We still provide the info for successful cases, even though it was in that case
already provided in the ResponseInfo of OnReceiveResponse.

 
     // Returns the URL of the request, which allows us to display it in
     // debugging situations.