Adding security info to canceled requests

webkit/glue/resource_loader_bridge.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The intent of this file is to provide a type-neutral abstraction between
 // Chrome and WebKit for resource loading. This pure-virtual interface is
 // implemented by the embedder, which also provides a factory method Create
 // to instantiate this object.
 //
 // One of these objects will be created by WebKit for each request. WebKit
@@ skipping 73 matching lines @@
     // deemed unsafe).
     virtual void OnReceivedResponse(const ResponseInfo& info,
                                     bool content_filtered) = 0;
 
     // Called when a chunk of response data is available.  This method may
     // be called multiple times or not at all if an error occurs.
     virtual void OnReceivedData(const char* data, int len) = 0;
 
     // Called when the response is complete.  This method signals completion of
     // the resource load.
-    virtual void OnCompletedRequest(const URLRequestStatus& status) = 0;
+    virtual void OnCompletedRequest(const URLRequestStatus& status,
+                                    const std::string& security_info) = 0;

[darin (slow to review), 2009/03/04 19:29:01]

so, iirc, we echo the security_info here in case OnReceivedResponse was not
called?  and that only happens in the case of an error, right?

[jcampan, 2009/03/04 22:33:43]

That's right, if the load of a resource failed we only get that call. The
provided security info can be used by the security filter peer and attached to
content they create. This is the case with sub-frames, if a sub-frame fails to
load because of a SSL error we replace it with some HTML showing an error. Since
now we attach the ssl info, the bad cert will be viewable for that frame.
We still provide the info for successful cases, even though it was in that case
already provided in the ResponseInfo of OnReceiveResponse.

 
     // Returns the URL of the request, which allows us to display it in
     // debugging situations.
     virtual std::string GetURLForDebugging() = 0;
   };
 
   // use Create() for construction, but anybody can delete at any time,
   // INCLUDING during processing of callbacks.
   virtual ~ResourceLoaderBridge() {}
 
@@ skipping 92 matching lines @@
   ResourceLoaderBridge() {}
 
  private:
   DISALLOW_EVIL_CONSTRUCTORS(ResourceLoaderBridge);
 };
 
 }  // namespace webkit_glue
 
 #endif  // RESOURCE_LOADER_BRIDGE__