Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: sky/engine/web/FrameLoaderClientImpl.cpp

Issue 727593004: Wire up the Inspector V8 Debugger (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Actually works Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/web/FrameLoaderClientImpl.cpp
diff --git a/sky/engine/web/FrameLoaderClientImpl.cpp b/sky/engine/web/FrameLoaderClientImpl.cpp
index 469dc178093bb8e3bd48b94b74daefd3885dfab7..1300e28d150618644b31fdc53d1d158684ddeec8 100644
--- a/sky/engine/web/FrameLoaderClientImpl.cpp
+++ b/sky/engine/web/FrameLoaderClientImpl.cpp
@@ -84,6 +84,10 @@ void FrameLoaderClientImpl::documentElementAvailable()
void FrameLoaderClientImpl::didCreateScriptContext(v8::Handle<v8::Context> context, int extensionGroup, int worldId)
{
+ // FIXME: We shouldn't need separate debugger ids in sky since
+ // we should have at most one DocumentView per process, no?
+ m_webFrame->frame()->script().setWorldDebugId(worldId, 1);
+
if (m_webFrame->client())
m_webFrame->client()->didCreateScriptContext(m_webFrame, context, extensionGroup, worldId);
}

Powered by Google App Engine
This is Rietveld 408576698