sky/engine/core/inspector/ScriptCallFrame.cpp - Issue 727593004: Wire up the Inspector V8 Debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/inspector/ScriptCallFrame.cpp

Issue 727593004: Wire up the Inspector V8 Debugger (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Actually works Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/inspector/ScriptCallFrame.cpp

diff --git a/sky/engine/core/inspector/ScriptCallFrame.cpp b/sky/engine/core/inspector/ScriptCallFrame.cpp

index d1e43cb939b18190bed8f029a2d72c012c2a88dd..ef69b23f06fc500f17a3b4139c117a4f13af6835 100644

--- a/sky/engine/core/inspector/ScriptCallFrame.cpp

+++ b/sky/engine/core/inspector/ScriptCallFrame.cpp

@@ -55,4 +55,15 @@ ScriptCallFrame::~ScriptCallFrame()

{

}

+PassRefPtr<TypeBuilder::Console::CallFrame> ScriptCallFrame::buildInspectorObject() const

+ return TypeBuilder::Console::CallFrame::create()

+ .setFunctionName(m_functionName)

+ .setScriptId(m_scriptId)

+ .setUrl(m_scriptName)

+ .setLineNumber(m_lineNumber)

+ .setColumnNumber(m_column)

+ .release();

} // namespace blink