Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: sky/engine/core/inspector/PageDebuggerAgent.h

Issue 727593004: Wire up the Inspector V8 Debugger (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Actually works Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/inspector/PageDebuggerAgent.h
diff --git a/sky/engine/core/rendering/OrderIterator.h b/sky/engine/core/inspector/PageDebuggerAgent.h
similarity index 56%
copy from sky/engine/core/rendering/OrderIterator.h
copy to sky/engine/core/inspector/PageDebuggerAgent.h
index 46666469ef0bd937b9b6dc0d9fc9743989808552..97530e37a275fedc9cb0330d6ef45c2906e48fc9 100644
--- a/sky/engine/core/rendering/OrderIterator.h
+++ b/sky/engine/core/inspector/PageDebuggerAgent.h
@@ -28,56 +28,46 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef OrderIterator_h
-#define OrderIterator_h
+#ifndef PageDebuggerAgent_h
+#define PageDebuggerAgent_h
-#include "wtf/Noncopyable.h"
-
-#include <set>
+#include "bindings/core/v8/PageScriptDebugServer.h"
+#include "core/inspector/InspectorDebuggerAgent.h"
namespace blink {
-class RenderBox;
-
-class OrderIterator {
- WTF_MAKE_NONCOPYABLE(OrderIterator);
-public:
- friend class OrderIteratorPopulator;
-
- OrderIterator(const RenderBox*);
-
- RenderBox* currentChild() const { return m_currentChild; }
- RenderBox* first();
- RenderBox* next();
- void reset();
-
-private:
- const RenderBox* m_containerBox;
-
- RenderBox* m_currentChild;
-
- typedef std::set<int> OrderValues;
- OrderValues m_orderValues;
- OrderValues::const_iterator m_orderValuesIterator;
- bool m_isReset;
-};
+class DocumentLoader;
+class InspectorPageAgent;
+class Page;
+class PageScriptDebugServer;
+class ScriptSourceCode;
-class OrderIteratorPopulator {
+class PageDebuggerAgent final
+ : public InspectorDebuggerAgent {
+ WTF_MAKE_NONCOPYABLE(PageDebuggerAgent);
+ WTF_MAKE_FAST_ALLOCATED;
public:
- explicit OrderIteratorPopulator(OrderIterator& iterator)
- : m_iterator(iterator)
- {
- m_iterator.m_orderValues.clear();
- }
-
- ~OrderIteratorPopulator();
+ static PassOwnPtr<PageDebuggerAgent> create(PageScriptDebugServer*, Page*, InjectedScriptManager*);
+ virtual ~PageDebuggerAgent();
- void collectChild(const RenderBox*);
+ void didClearDocumentOfWindowObject(LocalFrame*);
private:
- OrderIterator& m_iterator;
+ virtual void startListeningScriptDebugServer() override;
+ virtual void stopListeningScriptDebugServer() override;
+ virtual PageScriptDebugServer& scriptDebugServer() override;
+ virtual void muteConsole() override;
+ virtual void unmuteConsole() override;
+
+ virtual InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;
+ virtual void setOverlayMessage(ErrorString*, const String*) override;
+
+ PageDebuggerAgent(PageScriptDebugServer*, Page*, InjectedScriptManager*);
+ PageScriptDebugServer* m_pageScriptDebugServer;
+ Page* m_page;
};
} // namespace blink
-#endif // OrderIterator_h
+
+#endif // !defined(PageDebuggerAgent_h)

Powered by Google App Engine
This is Rietveld 408576698