Chromium Code Reviews Chromium Code Reviews
Issue 727593003:
Implement MouseEvent buttons attribute. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/events/mouse-event-buttons-attribute.html |
| diff --git a/LayoutTests/fast/events/mouse-event-buttons-attribute.html b/LayoutTests/fast/events/mouse-event-buttons-attribute.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..de4fcbdc2537d314156f448bc5191bd4ec65a4a0 |
| --- /dev/null |
| +++ b/LayoutTests/fast/events/mouse-event-buttons-attribute.html |
| @@ -0,0 +1,157 @@ |
| +<!DOCTYPE html> |
| +<div id="region" style="width:100px; height:100px; position:absolute; left:0px; top:0px;"></div> |
| +<script src="../../resources/js-test.js"></script> |
| +<script> |
| + |
| +const L = 'leftButton'; |
| +const R = 'rightButton'; |
| +const M = 'middleButton'; |
| +const TABLE = { |
| + 'leftButton': 1, |
| + 'rightButton': 2, |
| + 'middleButton': 4 |
| +}; |
| +const ME = 'MouseEvent'; |
| +const WE = 'WheelEvent'; |
| +const GE = 'GestureEvent'; |
| + |
| +var buttons = -2; |
| +var div = document.getElementById('region'); |
| +var testSet = [ |
| + { type: ME, name: 'dblclick', modifiers: [L], expectedModifiers: [], action: doubleClickAction }, |
| + { type: ME, name: 'click', modifiers: [L, R], expectedModifiers: [R], action: clickAction }, |
| + { type: ME, name: 'mousedown', modifiers: [L, M, R], action: clickAction }, |
| + { type: ME, name: 'mouseup', modifiers: [L, M, R], expectedModifiers: [M, R], action: clickAction }, |
| + { type: ME, name: 'mousemove', modifiers: [], action: moveAction }, |
| + { type: ME, name: 'mousemove', modifiers: [L], action: moveAction }, |
| + { type: ME, name: 'mouseenter', modifiers: [R, M], action: moveAction }, |
| + { type: ME, name: 'mouseleave', modifiers: [L, R], action: moveAction }, |
| + { type: ME, name: 'mouseover', modifiers: [L, M], action: moveAction }, |
| + { type: ME, name: 'mouseout', modifiers: [L], action: moveAction }, |
| + { type: ME, name: 'contextmenu', modifiers: [R], action: rightClickAction, showContextMenuOnMouseUp: false }, |
| + { type: ME, name: 'contextmenu', modifiers: [R], expectedModifiers: [], action: rightClickAction, showContextMenuOnMouseUp: true }, |
| + { type: WE, name: 'mousewheel', modifiers: [L, R], action: wheelAction }, |
| + { type: GE, name: 'dblclick', modifiers: [L], expectedModifiers: [], action: doubleTapAction }, |
| + { type: GE, name: 'click', modifiers: [L], expectedModifiers: [], action: tapAction }, |
| + { type: GE, name: 'mousedown', modifiers: [L], action: tapAction }, |
| + { type: GE, name: 'mouseup', modifiers: [L], expectedModifiers: [], action: tapAction }, |
| + { type: GE, name: 'mousemove', modifiers: [], action: tapAction }, |
| + { type: GE, name: 'mousedown', modifiers: [R], expectedModifiers: [R], action: longPressAction }, |
|
Rick Byers
2014/12/03 16:58:09
nit: you can remove the expectedModifiers here sin
zino
2014/12/04 06:40:05
Done.
|
| + { type: GE, name: 'contextmenu', modifiers: [R], action: longPressAction, showContextMenuOnMouseUp: false }, |
| + { type: GE, name: 'contextmenu', modifiers: [R], expectedModifiers: [], action: longPressAction, showContextMenuOnMouseUp: true }, |
| + { type: GE, name: 'contextmenu', modifiers: [R], action: longTapAction, showContextMenuOnMouseUp: false }, |
| + { type: GE, name: 'contextmenu', modifiers: [R], expectedModifiers: [], action: longTapAction, showContextMenuOnMouseUp: true }, |
| +]; |
| + |
| +function eventHandler(e) |
| +{ |
| + buttons = e.buttons; |
| +} |
| + |
| +function moveAction(modifiers) |
| +{ |
| + eventSender.mouseMoveTo(-1, -1, modifiers); |
| + eventSender.mouseMoveTo(50, 50, modifiers); |
| +} |
| + |
| +function clickAction(modifiers) |
| +{ |
| + moveAction(modifiers); |
| + eventSender.mouseDown(0, modifiers); |
| + eventSender.mouseUp(0, modifiers); |
| +} |
| + |
| +function rightClickAction(modifiers) |
| +{ |
| + moveAction(modifiers); |
| + eventSender.mouseDown(2, modifiers); |
| + eventSender.mouseUp(2, modifiers); |
| +} |
| + |
| +function doubleClickAction(modifiers) |
| +{ |
| + clickAction(modifiers); |
| + clickAction(modifiers); |
| +} |
| + |
| +function wheelAction(modifiers) |
| +{ |
| + moveAction(modifiers); |
| + eventSender.mouseScrollBy(0, 120, false, true, modifiers); |
| +} |
| + |
| +function tapAction(modifiers) |
| +{ |
| + eventSender.gestureTap(50, 50); |
| +} |
| + |
| +function longPressAction(modifiers) |
| +{ |
| + eventSender.gestureLongPress(50, 50); |
| +} |
| + |
| +function longTapAction(modifiers) |
| +{ |
| + eventSender.gestureLongPress(50, 50); |
| + eventSender.gestureLongTap(50, 50); |
| +} |
| + |
| +function doubleTapAction(modifiers) |
| +{ |
| + eventSender.gestureTap(50, 50, 2); |
| +} |
| + |
| +function raiseEvent(n) |
| +{ |
| + if (!window.eventSender) |
| + return; |
| + |
| + div.addEventListener(testSet[n].name, eventHandler, false); |
| + testSet[n].action(testSet[n].modifiers); |
| + testSet[n].buttons = buttons; |
| + div.removeEventListener(testSet[n].name, eventHandler, false); |
| + buttons = -1; |
| +} |
| + |
| +function expectedValue(testItem) |
| +{ |
| + var modifiers; |
| + if (testItem.expectedModifiers != undefined) |
| + modifiers = testItem.expectedModifiers; |
| + else |
| + modifiers = testItem.modifiers; |
| + |
| + var value = 0; |
| + for (var i = 0; i < modifiers.length; i++) |
| + value |= TABLE[modifiers[i]]; |
| + |
| + return value; |
| +} |
| + |
| +function printTestInfo(testItem) |
| +{ |
| + var expectedModifiers = ' -> shouldBe([' + testSet[i].modifiers +'])'; |
| + var showContextMenuOnMouseUp = ""; |
| + if (testSet[i].expectedModifiers != undefined) |
| + expectedModifiers = ' -> shouldBe([' + testSet[i].expectedModifiers + '])'; |
|
Rick Byers
2014/12/03 16:58:09
nit: avoid duplicating your strings here. Eg. you
zino
2014/12/04 06:40:05
Done.
|
| + if (testSet[i].showContextMenuOnMouseUp != undefined) |
| + showContextMenuOnMouseUp = " with |showContextMenuOnMouseUp=" + |
| + testSet[i].showContextMenuOnMouseUp + "|"; |
| + debug(testSet[i].type + '::' + testSet[i].name + showContextMenuOnMouseUp + ' ' |
| + + testSet[i].action.name + '([' + testSet[i].modifiers + '])' + expectedModifiers); |
| +} |
| + |
| +for (var i = 0; i < testSet.length; i++) { |
| + var showContextMenuOnMouseUp; |
|
Rick Byers
2014/12/03 16:58:09
Note that comparing to undefined in javascript is
zino
2014/12/04 06:40:05
Done.
|
| + if (testSet[i].showContextMenuOnMouseUp == undefined) |
| + showContextMenuOnMouseUp = false; |
| + else |
| + showContextMenuOnMouseUp = testSet[i].showContextMenuOnMouseUp; |
| + internals.settings.setShowContextMenuOnMouseUp(showContextMenuOnMouseUp); |
| + raiseEvent(i); |
| + printTestInfo(testSet[i]); |
| + shouldBeEqualToNumber('testSet[i].buttons', expectedValue(testSet[i])); |
| + debug(''); |
| +} |
| + |
| +</script> |
