Source/web/tests/WebFrameTest.cpp - Issue 727593003: Implement MouseEvent buttons attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 727593003: Implement MouseEvent buttons attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 3ad4eae88fa0455a32b0c77ae5794bf2b6e771c0..6b34c0bca03b154b549543639ec580acb8daa831 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -5498,7 +5498,7 @@ TEST_F(WebFrameTest, SimulateFragmentAnchorMiddleClick)

destination.setFragmentIdentifier("test");

RefPtrWillBeRawPtr<Event> event = MouseEvent::create(EventTypeNames::click, false, false,

- document->domWindow(), 0, 0, 0, 0, 0, 0, 0, false, false, false, false, 1, nullptr, nullptr);

+ document->domWindow(), 0, 0, 0, 0, 0, 0, 0, false, false, false, false, 1, 0, nullptr, nullptr);

FrameLoadRequest frameRequest(document, ResourceRequest(destination));

frameRequest.setTriggeringEvent(event);

toLocalFrame(webViewHelper.webViewImpl()->page()->mainFrame())->loader().load(frameRequest);

@@ -5547,7 +5547,7 @@ TEST_F(WebFrameTest, ModifiedClickNewWindow)

// ctrl+click event

RefPtrWillBeRawPtr<Event> event = MouseEvent::create(EventTypeNames::click, false, false,

- document->domWindow(), 0, 0, 0, 0, 0, 0, 0, true, false, false, false, 0, nullptr, nullptr);

+ document->domWindow(), 0, 0, 0, 0, 0, 0, 0, true, false, false, false, 0, 0, nullptr, nullptr);

FrameLoadRequest frameRequest(document, ResourceRequest(destination));

frameRequest.setTriggeringEvent(event);

UserGestureIndicator gesture(DefinitelyProcessingUserGesture);