Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: Source/platform/PlatformMouseEvent.h

Issue 727593003: Implement MouseEvent buttons attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/PlatformMouseEvent.h
diff --git a/Source/platform/PlatformMouseEvent.h b/Source/platform/PlatformMouseEvent.h
index 488bd0c211c910e5137fe452603608f3484de634..1ec3b0a98d32da301577ca1a0dedbf046f5b1021 100644
--- a/Source/platform/PlatformMouseEvent.h
+++ b/Source/platform/PlatformMouseEvent.h
@@ -46,6 +46,7 @@ public:
PlatformMouseEvent()
: PlatformEvent(PlatformEvent::MouseMoved)
, m_button(NoButton)
+ , m_buttons(0)
, m_clickCount(0)
, m_synthesized(RealOrIndistinguishable)
, m_modifierFlags(0)
@@ -57,6 +58,7 @@ public:
, m_position(position)
, m_globalPosition(globalPosition)
, m_button(button)
+ , m_buttons(0)
, m_clickCount(clickCount)
, m_synthesized(RealOrIndistinguishable)
, m_modifierFlags(0)
@@ -68,6 +70,7 @@ public:
, m_position(position)
, m_globalPosition(globalPosition)
, m_button(button)
+ , m_buttons(0)
, m_clickCount(clickCount)
, m_synthesized(synthesized)
, m_modifierFlags(0)
@@ -79,6 +82,7 @@ public:
, m_position(position)
, m_globalPosition(globalPosition)
, m_button(button)
+ , m_buttons(0)
Rick Byers 2014/11/14 19:48:09 I think using 0 here is a bug. You probably need
zino 2014/11/18 14:19:35 Good point! Thank you. Done.
, m_clickCount(clickCount)
, m_synthesized(synthesized)
, m_modifierFlags(0)
@@ -90,6 +94,7 @@ public:
const IntPoint& movementDelta() const { return m_movementDelta; }
MouseButton button() const { return m_button; }
+ unsigned short buttons() const { return m_buttons; }
int clickCount() const { return m_clickCount; }
unsigned modifierFlags() const { return m_modifierFlags; }
bool fromTouch() const { return m_synthesized == FromTouch; }
@@ -100,6 +105,7 @@ protected:
IntPoint m_globalPosition;
IntPoint m_movementDelta;
MouseButton m_button;
+ unsigned short m_buttons;
int m_clickCount;
SyntheticEventType m_synthesized;
unsigned m_modifierFlags;

Powered by Google App Engine
This is Rietveld 408576698