Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: Source/core/page/EventHandler.cpp

Issue 727593003: Implement MouseEvent buttons attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp
index 3d1279c3b704166d04a0ca9dd72322472a2267e8..84c84a359d3487705b0fb87ed2ee423907837eb1 100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -1640,7 +1640,7 @@ bool EventHandler::dispatchDragEvent(const AtomicString& eventType, Node* dragTa
0, event.globalPosition().x(), event.globalPosition().y(), event.position().x(), event.position().y(),
event.movementDelta().x(), event.movementDelta().y(),
event.ctrlKey(), event.altKey(), event.shiftKey(), event.metaKey(),
- 0, nullptr, dataTransfer);
+ 0, 0, nullptr, dataTransfer);
Rick Byers 2014/11/14 19:48:09 This looks like a bug too. DragEvent is a MouseEv
zino 2014/11/18 14:19:35 I left a FIXME comment. This seems to be non-trivi
Rick Byers 2014/11/18 20:29:18 Ok. Thanks for adding the RuntimeEnabledFeature -
dragTarget->dispatchEvent(me.get(), IGNORE_EXCEPTION);
return me->defaultPrevented();

Powered by Google App Engine
This is Rietveld 408576698