LayoutTests/fast/events/mouse-event-buttons-attribute.html - Issue 727593003: Implement MouseEvent buttons attribute.

Unified Diff: LayoutTests/fast/events/mouse-event-buttons-attribute.html

Issue 727593003: Implement MouseEvent buttons attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/events/mouse-event-buttons-attribute.html

diff --git a/LayoutTests/fast/events/mouse-event-buttons-attribute.html b/LayoutTests/fast/events/mouse-event-buttons-attribute.html

new file mode 100644

index 0000000000000000000000000000000000000000..b6f0e76567e818df606922ad718a0517ff77987a

--- /dev/null

+++ b/LayoutTests/fast/events/mouse-event-buttons-attribute.html

@@ -0,0 +1,25 @@

+<!DOCTYPE html>

+<script src="../../resources/js-test.js"></script>

+<script>

+if (window.testRunner)

+ testRunner.waitUntilDone();

Rick Byers 2014/11/14 19:48:09 eventSender works synchronously, you can simplify

zino 2014/11/18 14:19:35 Done.

+window.addEventListener('mousedown', function() {

Rick Byers 2014/11/14 19:48:09 Please add handlers for the other event types too

zino 2014/11/18 14:19:35 Done.

Rick Byers 2014/11/18 20:29:18 The spec (http://www.w3.org/TR/DOM-Level-3-Events/

The spec (http://www.w3.org/TR/DOM-Level-3-Events/#widl-MouseEvent-buttons) says that 'buttons' indicates which buttons "are currently being pressed". So what is the correct interpretation for a mouseup event where a button was just released? Eg. try clicking with the left mouse button at http://www.rbyers.net/eventTest.html on a couple browsers. In Firefox and IE on Windows I get: mousedown: ... button=0 buttons=1 ... mouseup: ... button=0 buttons=0 ... click: ... button=0 buttons=0 ... mousemove[28]: ... button=0 buttons=0 ... But in Firefox on Linux I get: mousedown: ... button=0 buttons=1 ... mouseup: ... button=0 buttons=1 ... click: ... button=0 buttons=1 ... mousemove[28]: ... button=0 buttons=0 ... The former seems correct according to the spec to me, the latter is probably a bug in Firefox. Which behavior does Chromium have?

You still need this. Eg. 'var evt = new MouseEvent( {.... buttons: 2 }); shouldBeNumber("buttons", "evt.buttons");

Yeah I think this is fine. I tried this on IE - see http://jsbin.com/tesopu/65/edit?js,output. On IE it displays: mousedown button=2 buttons=0 Technically this could confuse some code (buttons should never be 0 in a mousedown event), but it's probably not worth trying to do something about this.

zino 2014/11/24 13:07:07 Okay, I've addressed the bug.

Rick Byers 2014/11/25 17:44:27 I was thinking this would be addressed in chromium

+ if (window.eventSender) {

+ window.result = event.buttons;

+ shouldBe('result', '3');

+ } else {

+ debug('event.buttons = ' + event.buttons);

+ }

+ if (window.testRunner)

+ testRunner.notifyDone();

+}, false);

+if (window.eventSender) {

+ eventSender.mouseMoveTo(10, 10);

+ eventSender.mouseDown(1, ['leftButton', 'rightButton']);

+</script>

« no previous file with comments | « no previous file | LayoutTests/fast/events/mouse-event-buttons-attribute-expected.txt » ('j') | Source/core/events/WheelEvent.cpp » ('J')