LayoutTests/fast/events/mouse-event-buttons-attribute-expected.txt - Issue 727593003: Implement MouseEvent buttons attribute.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/mouse-event-buttons-attribute-expected.txt

Issue 727593003: Implement MouseEvent buttons attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/events/mouse-event-buttons-attribute.html ('K') | « LayoutTests/fast/events/mouse-event-buttons-attribute.html ('k') | Source/core/events/MouseEvent.h » ('j') | Source/core/events/MouseEvent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 MouseEvent::dblclick test [leftButton]

	2 PASS testSet[i].buttons is 1
	Rick Byers 2014/11/25 17:44:27 this should be 0 (like mouseup). this should be 0 (like mouseup). zino 2014/11/28 12:29:28 Done. Show quoted text On 2014/11/25 17:44:27, Rick Byers wrote: > this should be 0 (like mouseup). Done.
	3

	4 MouseEvent::click test [leftButton,rightButton]

	5 PASS testSet[i].buttons is 3
	Rick Byers 2014/11/25 17:44:27 and this should be 2. and this should be 2. zino 2014/11/28 12:29:28 Done. Show quoted text On 2014/11/25 17:44:27, Rick Byers wrote: > and this should be 2. Done.
	6

	7 MouseEvent::mousedown test [leftButton,middleButton,rightButton]

	8 PASS testSet[i].buttons is 7

	9

	10 MouseEvent::mouseup test [leftButton,middleButton,rightButton] -> [leftButton,ri ghtButton]

	11 PASS testSet[i].buttons is 3

	12

	13 MouseEvent::mousemove test []

	14 PASS testSet[i].buttons is 0

	15

	16 MouseEvent::mousemove test [leftButton]

	17 PASS testSet[i].buttons is 1

	18

	19 MouseEvent::mouseenter test [rightButton,middleButton]

	20 PASS testSet[i].buttons is 6

	21

	22 MouseEvent::mouseleave test [leftButton,rightButton]

	23 PASS testSet[i].buttons is 3

	24

	25 MouseEvent::mouseover test [leftButton,middleButton]

	26 PASS testSet[i].buttons is 5

	27

	28 MouseEvent::mouseout test [leftButton]

	29 PASS testSet[i].buttons is 1

	30

	31 MouseEvent::contextmenu test [rightButton]

	32 PASS testSet[i].buttons is 2
	Rick Byers 2014/11/25 17:44:27 Another example where I think this should be 0, no Another example where I think this should be 0, not 2. I confirmed IE and Firefox on Windows. zino 2014/11/28 02:37:09 Here. Show quoted text On 2014/11/25 17:44:27, Rick Byers wrote: > Another example where I think this should be 0, not 2. I confirmed IE and > Firefox on Windows. Here. zino 2014/11/28 12:29:28 If this is correct, you can see the patch set 7. B Show quoted text On 2014/11/25 17:44:27, Rick Byers wrote: > Another example where I think this should be 0, not 2. I confirmed IE and > Firefox on Windows. If this is correct, you can see the patch set 7. But if the value should be 2, you will see the patch set 6.
	33

	34 WheelEvent::mousewheel test [leftButton,rightButton]

	35 PASS testSet[i].buttons is 3

	36

	37 GestureEvent::dblclick test [leftButton]

	38 PASS testSet[i].buttons is 1

	39

	40 GestureEvent::click test [leftButton]

	41 PASS testSet[i].buttons is 1

	42

	43 GestureEvent::mousedown test [leftButton]

	44 PASS testSet[i].buttons is 1

	45

	46 GestureEvent::mouseup test [leftButton] -> []

	47 PASS testSet[i].buttons is 0

	48

	49 GestureEvent::mousemove test []

	50 PASS testSet[i].buttons is 0

	51

	52 GestureEvent::contextmenu test [rightButton]

	53 PASS testSet[i].buttons is 2

	54

	55 PASS successfullyParsed is true

	56

	57 TEST COMPLETE

	58

OLD	NEW