Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 727583003: Subzero: Update the README file. (Closed)

Created:
6 years, 1 month ago by Jim Stichnoth
Modified:
6 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Update the README file. It's not meant to be comprehensive, but rather to help someone new get started, assuming they already have PNaCl working. BUG= none R=jfb@chromium.org, jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=144a393b4e66077dcad46c3dd4ac12a9d84f5cfe

Patch Set 1 #

Patch Set 2 : Small updates #

Total comments: 4

Patch Set 3 : Code review changes #

Total comments: 2

Patch Set 4 : Add comment about --no-strip-syms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -29 lines) Patch
M README.rst View 1 2 3 3 chunks +120 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jim Stichnoth
6 years, 1 month ago (2014-11-18 15:48:20 UTC) #2
JF
lgtm https://codereview.chromium.org/727583003/diff/20001/README.rst File README.rst (right): https://codereview.chromium.org/727583003/diff/20001/README.rst#newcode9 README.rst:9: https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/developing-pnacl follow `the instructions < https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/developing-pnacl>`_ https://codereview.chromium.org/727583003/diff/20001/README.rst#newcode42 README.rst:42: ...
6 years, 1 month ago (2014-11-18 15:57:09 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/727583003/diff/20001/README.rst File README.rst (right): https://codereview.chromium.org/727583003/diff/20001/README.rst#newcode9 README.rst:9: https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/developing-pnacl On 2014/11/18 15:57:08, JF wrote: > follow `the ...
6 years, 1 month ago (2014-11-18 16:18:57 UTC) #5
jvoung (off chromium)
lgtm https://codereview.chromium.org/727583003/diff/40001/README.rst File README.rst (right): https://codereview.chromium.org/727583003/diff/40001/README.rst#newcode136 README.rst:136: pexe files have been built. I find it ...
6 years, 1 month ago (2014-11-18 16:56:20 UTC) #6
Jim Stichnoth
https://codereview.chromium.org/727583003/diff/40001/README.rst File README.rst (right): https://codereview.chromium.org/727583003/diff/40001/README.rst#newcode136 README.rst:136: pexe files have been built. On 2014/11/18 16:56:20, jvoung ...
6 years, 1 month ago (2014-11-18 17:07:03 UTC) #7
Jim Stichnoth
6 years, 1 month ago (2014-11-18 17:16:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
144a393b4e66077dcad46c3dd4ac12a9d84f5cfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698