Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: ui/base/accelerators/accelerator_history.h

Issue 727583002: Regression: Search+Key pops up app launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/accelerators/accelerator_history.h
diff --git a/ui/base/accelerators/accelerator_history.h b/ui/base/accelerators/accelerator_history.h
new file mode 100644
index 0000000000000000000000000000000000000000..4e0a814ad402b02d7f82eae4fc0a449244d6041e
--- /dev/null
+++ b/ui/base/accelerators/accelerator_history.h
@@ -0,0 +1,61 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_ACCELERATORS_ACCELERATOR_HISTORY_H_
+#define UI_BASE_ACCELERATORS_ACCELERATOR_HISTORY_H_
+
+#include "base/memory/singleton.h"
+#include "ui/base/accelerators/accelerator.h"
+#include "ui/base/ui_base_export.h"
+#include "ui/events/event.h"
+#include "ui/events/event_handler.h"
+
+namespace ui {
+
+// ----------------------------------------------------------------------
+// Keeps track of the system-wide current and the most recent previous
+// key accelerators.
+// ----------------------------------------------------------------------
+class UI_BASE_EXPORT AcceleratorHistory : public EventHandler {
+ public:
+ static AcceleratorHistory* GetInstance();
+
+ // Returns the most recent recorded accelerator.
+ const Accelerator& GetCurrentAccelerator() const;
+
+ // Returns the most recent previously recorded accelerator that is different
+ // than the current.
+ const Accelerator& GetPreviousAccelerator() const;
+
+ // Stores the given |accelerator| only if it's different than the currently
+ // stored one.
+ void StoreCurrentAccelerator(const Accelerator& accelerator);
+
+ private:
+ friend struct DefaultSingletonTraits<AcceleratorHistory>;
+
+ AcceleratorHistory();
+ ~AcceleratorHistory();
+
+ // From ui::EventHandler
Jun Mukai 2014/11/15 01:56:33 common style of the comment is: // ui::EventHandle
afakhry 2014/11/15 02:40:31 Done.
+ void OnKeyEvent(KeyEvent* event) override;
+
+ // Builds and records the current accelerator using the given |event|.
+ void BuildCurrentAccelerator(const ui::KeyEvent& event);
+
+ // We are only interested in the most recent 'different' accelerator. If the
+ // new |event| will result in the same current accelerator then we should
+ // ignore it.
+ bool ShouldBuildCurrentAccelerator(const ui::KeyEvent& event,
+ const int event_modifiers) const;
+
+ Accelerator current_accelerator_;
+ Accelerator previous_accelerator_;
+
+ DISALLOW_COPY_AND_ASSIGN(AcceleratorHistory);
+};
+
+}; // namespace ui
+
+#endif // UI_BASE_ACCELERATORS_ACCELERATOR_HISTORY_H_
« ash/shell.cc ('K') | « ash/shell.cc ('k') | ui/base/accelerators/accelerator_history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698