Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: ash/accelerators/accelerator_controller.h

Issue 727583002: Regression: Search+Key pops up app launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/accelerators/accelerator_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/accelerators/accelerator_controller.h
diff --git a/ash/accelerators/accelerator_controller.h b/ash/accelerators/accelerator_controller.h
index 0ca515b3fc36edadc8c9089f90ee469e1170bb47..82d1a369e9fad69646588bf2d0c1b6461009074b 100644
--- a/ash/accelerators/accelerator_controller.h
+++ b/ash/accelerators/accelerator_controller.h
@@ -16,6 +16,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
#include "ui/base/accelerators/accelerator.h"
+#include "ui/base/accelerators/accelerator_history.h"
namespace ui {
class AcceleratorManager;
@@ -112,8 +113,8 @@ class ASH_EXPORT AcceleratorController : public ui::AcceleratorTarget {
return &exit_warning_handler_;
}
- const ui::Accelerator& previous_accelerator_for_test() const {
- return previous_accelerator_;
+ ui::AcceleratorHistory* accelerator_history() {
+ return accelerator_history_.get();
}
// Overridden from ui::AcceleratorTarget:
@@ -149,6 +150,9 @@ class ASH_EXPORT AcceleratorController : public ui::AcceleratorTarget {
scoped_ptr<ui::AcceleratorManager> accelerator_manager_;
+ // A tracker for the current and previous accelerators.
+ scoped_ptr<ui::AcceleratorHistory> accelerator_history_;
+
// TODO(derat): BrightnessControlDelegate is also used by the system tray;
// move it outside of this class.
scoped_ptr<BrightnessControlDelegate> brightness_control_delegate_;
@@ -157,10 +161,6 @@ class ASH_EXPORT AcceleratorController : public ui::AcceleratorTarget {
keyboard_brightness_control_delegate_;
scoped_ptr<ScreenshotDelegate> screenshot_delegate_;
- // Remember previous accelerator as some accelerator needs to be fired
- // with a specific sequence.
- ui::Accelerator previous_accelerator_;
-
// Handles the exit accelerator which requires a double press to exit and
// shows a popup with an explanation.
ExitWarningHandler exit_warning_handler_;
« no previous file with comments | « no previous file | ash/accelerators/accelerator_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698