Regression: Search+Key pops up app launcher

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 
@@ skipping 449 matching lines @@
   return true;
 }
 
 bool HandleToggleAppList(ui::KeyboardCode key_code,
                          ui::EventType previous_event_type,
                          ui::KeyboardCode previous_key_code,
                          const ui::Accelerator& accelerator) {
   // If something else was pressed between the Search key (LWIN)
   // being pressed and released, then ignore the release of the
   // Search key.
-  if (key_code == ui::VKEY_LWIN &&
-      (previous_event_type == ui::ET_KEY_RELEASED ||
-       previous_key_code != ui::VKEY_LWIN))
+  if (key_code != ui::VKEY_LWIN ||
+      previous_event_type != ui::ET_KEY_PRESSED ||
+      previous_key_code != ui::VKEY_LWIN ||
+      accelerator.type() != ui::ET_KEY_RELEASED)

[Jun Mukai, 2014/11/15 01:56:33]

This means accelerator is not handled at all if key code is not VKEY_LWIN.  Is
that true?
accelerator_table has a mapping of VKEY_BROWSER_SEARCH.  Isn't it currently
used?

[Jun Mukai, 2014/11/15 01:56:33]

This was weird in the previous code.  Multi-lined if should have curly braces.
Could you add that?

[afakhry, 2014/11/15 02:40:30]

Done.

[afakhry, 2014/11/15 02:40:31]

I added a test for VKEY_BROWSER_SEARCH and pressed.

     return false;
-  if (key_code == ui::VKEY_LWIN)
-    base::RecordAction(base::UserMetricsAction("Accel_Search_LWin"));
+
+  base::RecordAction(base::UserMetricsAction("Accel_Search_LWin"));
+
   // When spoken feedback is enabled, we should neither toggle the list nor
   // consume the key since Search+Shift is one of the shortcuts the a11y
   // feature uses. crbug.com/132296
   DCHECK_EQ(ui::VKEY_LWIN, accelerator.key_code());

[afakhry, 2014/11/15 03:04:58]

I also removed this line as it doesn't take into consideration
VKEY_BROWSER_SEARCH

   if (Shell::GetInstance()->accessibility_delegate()->
       IsSpokenFeedbackEnabled())
     return false;
   ash::Shell::GetInstance()->ToggleAppList(NULL);
   return true;
 }
 
 bool HandleToggleFullscreen(ui::KeyboardCode key_code) {
   if (key_code == ui::VKEY_MEDIA_LAUNCH_APP2) {
     base::RecordAction(UserMetricsAction("Accel_Fullscreen_F4"));
@@ skipping 160 matching lines @@
       chromeos::input_method::InputMethodManager::Get();
   chromeos::input_method::ImeKeyboard* keyboard =
       ime ? ime->GetImeKeyboard() : NULL;
   if (keyboard)
     keyboard->SetCapsLockEnabled(!keyboard->CapsLockIsEnabled());
   return true;
 }
 
 #endif  // defined(OS_CHROMEOS)
 
-class AutoSet {
- public:
-  AutoSet(ui::Accelerator* scoped, ui::Accelerator new_value)
-      : scoped_(scoped), new_value_(new_value) {}
-  ~AutoSet() { *scoped_ = new_value_; }
-
- private:
-  ui::Accelerator* scoped_;
-  const ui::Accelerator new_value_;
-
-  DISALLOW_COPY_AND_ASSIGN(AutoSet);
-};
-
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // AcceleratorController, public:
 
 AcceleratorController::AcceleratorController()
     : accelerator_manager_(new ui::AcceleratorManager) {
   Init();
 }
 
 AcceleratorController::~AcceleratorController() {
 }
 
 void AcceleratorController::Init() {
-  previous_accelerator_.set_type(ui::ET_UNKNOWN);
   for (size_t i = 0; i < kActionsAllowedAtLoginOrLockScreenLength; ++i) {
     actions_allowed_at_login_screen_.insert(
         kActionsAllowedAtLoginOrLockScreen[i]);
     actions_allowed_at_lock_screen_.insert(
         kActionsAllowedAtLoginOrLockScreen[i]);
   }
   for (size_t i = 0; i < kActionsAllowedAtLockScreenLength; ++i)
     actions_allowed_at_lock_screen_.insert(kActionsAllowedAtLockScreen[i]);
   for (size_t i = 0; i < kActionsAllowedAtModalWindowLength; ++i)
     actions_allowed_at_modal_window_.insert(kActionsAllowedAtModalWindow[i]);
@@ skipping 33 matching lines @@
 void AcceleratorController::Unregister(const ui::Accelerator& accelerator,
                                        ui::AcceleratorTarget* target) {
   accelerator_manager_->Unregister(accelerator, target);
 }
 
 void AcceleratorController::UnregisterAll(ui::AcceleratorTarget* target) {
   accelerator_manager_->UnregisterAll(target);
 }
 
 bool AcceleratorController::Process(const ui::Accelerator& accelerator) {
-  AutoSet auto_set(&previous_accelerator_, accelerator);
-
   if (ime_control_delegate_) {
     return accelerator_manager_->Process(
         ime_control_delegate_->RemapAccelerator(accelerator));
   }
   return accelerator_manager_->Process(accelerator);
 }
 
 bool AcceleratorController::IsRegistered(
     const ui::Accelerator& accelerator) const {
   return accelerator_manager_->GetCurrentTarget(accelerator) != NULL;
@@ skipping 38 matching lines @@
   // empty Accelerator() instance as the second argument. Such events
   // should never be suspended.
   const bool gesture_event = key_code == ui::VKEY_UNKNOWN;
   // Ignore accelerators invoked as repeated (while holding a key for a long
   // time, if their handling is nonrepeatable.
   if (nonrepeatable_actions_.find(action) != nonrepeatable_actions_.end() &&
       accelerator.IsRepeat() && !gesture_event) {
     return true;
   }
   // Type of the previous accelerator. Used by NEXT_IME and DISABLE_CAPS_LOCK.
-  const ui::EventType previous_event_type = previous_accelerator_.type();
-  const ui::KeyboardCode previous_key_code = previous_accelerator_.key_code();
+  const ui::Accelerator& previous_accelerator =
+      ui::AcceleratorHistory::GetInstance()->GetPreviousAccelerator();
+  const ui::EventType previous_event_type = previous_accelerator.type();
+  const ui::KeyboardCode previous_key_code = previous_accelerator.key_code();
 
   // You *MUST* return true when some action is performed. Otherwise, this
   // function might be called *twice*, via BrowserView::PreHandleKeyboardEvent
   // and BrowserView::HandleKeyboardEvent, for a single accelerator press.
   //
   // If your accelerator invokes more than one line of code, please either
   // implement it in your module's controller code (like TOGGLE_MIRROR_MODE
   // below) or pull it into a HandleFoo() function above.
   switch (action) {
     case ACCESSIBLE_FOCUS_NEXT:
@@ skipping 294 matching lines @@
     keyboard_brightness_control_delegate) {
   keyboard_brightness_control_delegate_ =
       keyboard_brightness_control_delegate.Pass();
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash