ui/events/DEPS - Issue 727583002: Regression: Search+Key pops up app launcher

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/DEPS

Issue 727583002: Regression: Search+Key pops up app launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+ui/base",
	Jun Mukai 2014/11/14 02:09:48 Aagh. ui/base already depends on ui/events, so ad Aagh. ui/base already depends on ui/events, so adding this will lead to a cycle dependency, which doesn't look great. Could you find the way to avoid this? I think building accelerator can be done as a PreHandleEventFilter
2 "+ui/gfx",	3 "+ui/gfx",

3 ]	4 ]

OLD	NEW